Re: [PATCH RFT v2 0/5] i3c: introduce and use generic parity helper

From: Yury Norov <yury.norov@gmail.com>
To: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Jean Delvare" <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org, "Przemysław Gaj" <pgaj@cadence.com>
Cc: linus@ucla.edu
Subject: Re: [PATCH RFT v2 0/5] i3c: introduce and use generic parity helper
Date: Sat, 4 Jan 2025 19:38:55 -0800	[thread overview]
Message-ID: <Z3n-z5xA2ue8ojiF@yury-ThinkPad> (raw)
In-Reply-To: <Z3hhw_pwFAicsEDi@shikoro>

On Fri, Jan 03, 2025 at 11:16:35PM +0100, Wolfram Sang wrote:
> 
> > I'll apply the series once you get some agreement on the function name.
> 
> Thanks!
> 
> As said in that thread, the function name has already been changed in v2
> to the liking of the bitmap.h maintainer (Rasmus) [1]. He has not
> responded to this series yet, though.
> 
> [1] https://lore.kernel.org/r/CAKwiHFiamZ7FgS3wbyLHo6n6R136LrLVCsih0w+spG55BPxy8g@mail.gmail.com
> 

+ Linus Arver

Rasmus is reviewer. I'm - maintainer. But I surely agreed with him.
Shorter name is always better. And we're all kernel developers here,
so we used to read and respect comments. The comment clearly explains
what the function returns.

I'm a bit doubted about adding a web link in sources because it may
become invalid one day, but if Wolfram commits to maintain comments
up-to-date, I'm OK with that.

I already acked the patch, so no need to ack it again.

Thanks,
Yury

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c