From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Frank Li <Frank.li@nxp.com>
Cc: "Jorge Marques" <jorge.marques@analog.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Przemysław Gaj" <pgaj@cadence.com>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and i3c_writel_fifo()
Date: Tue, 24 Jun 2025 22:30:42 +0200 [thread overview]
Message-ID: <aFsK8sDj7WvIBZvW@shikoro> (raw)
In-Reply-To: <aFrpra9j69OkkMbL@lizhi-Precision-Tower-5810>
[-- Attachment #1.1: Type: text/plain, Size: 816 bytes --]
On Tue, Jun 24, 2025 at 02:08:45PM -0400, Frank Li wrote:
> On Tue, Jun 24, 2025 at 11:06:04AM +0200, Jorge Marques wrote:
> > The I3C abstraction expects u8 buffers, but some controllers operate with
> > a 32-bit bus width FIFO and cannot flag valid bytes individually. To avoid
> > reading or writing outside the buffer bounds, use 32-bit accesses where
> > possible and apply memcpy for any remaining bytes
> >
> > Signed-off-by: Jorge Marques <jorge.marques@analog.com>
>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> > ---
> > drivers/i3c/internals.h | 37 +++++++++++++++++++++++++++++++++++++
Is there a reason we don't put this in 'include/linux/i3c/master.h'?
'internals.h' is used for the core only so far, and '#include
<../something.h>' also looks a bit like a layering violation.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 111 bytes --]
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-07-02 22:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 9:06 [PATCH v3 0/3] Add helper methods i3c_writel_fifo() and i3c_readl_fifo() Jorge Marques
2025-06-24 9:06 ` [PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and i3c_writel_fifo() Jorge Marques
2025-06-24 18:08 ` Frank Li
2025-06-24 20:30 ` Wolfram Sang [this message]
2025-06-24 21:13 ` Frank Li
2025-06-25 7:20 ` Wolfram Sang
2025-06-25 7:24 ` Wolfram Sang
2025-06-24 9:06 ` [PATCH v3 2/3] i3c: master: cdns: Use i3c_writel_fifo() and i3c_readl_fifo() Jorge Marques
2025-06-24 18:09 ` Frank Li
2025-06-25 7:26 ` Wolfram Sang
2025-06-24 9:06 ` [PATCH v3 3/3] i3c: master: dw: " Jorge Marques
2025-06-24 18:10 ` Frank Li
2025-06-25 7:27 ` Wolfram Sang
2025-07-30 23:40 ` [PATCH v3 0/3] Add helper methods " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFsK8sDj7WvIBZvW@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=Frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=jorge.marques@analog.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pgaj@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox