From: vitor.soares@synopsys.com (vitor)
To: linux-i3c@lists.infradead.org
Subject: i3c_master_add_i3c_dev_locked() accept PID, BCR, DCR
Date: Mon, 10 Dec 2018 19:21:37 +0000 [thread overview]
Message-ID: <fd731fb8-3b47-9364-baf7-da530bf9c786@synopsys.com> (raw)
Hi,
The function bellow doesn't accept the PID, BCR and DCR captured
during the ENTDAA.
int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master,
?? ??? ??? ??? ?? u8 addr)
{
?? ?struct i3c_device_info info = { .dyn_addr = addr };
I would like to change it to received those parameters. Something like this:
int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master,
?? ??? ??? ??? ?? u64 pid, u8 bcr, u8 dcr, u8 addr)
{
?? ?struct i3c_device_info info = { .pid = pid,
?? ??? ??? ??? ??? ?.bcr = bcr,
?? ??? ??? ??? ??? ?.dcr = dcr,
?? ??? ??? ??? ??? ?.dyn_addr = addr };
Do you agree?
Best regards,
Vitor Soares
next reply other threads:[~2018-12-10 19:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 19:21 vitor [this message]
2018-12-10 19:43 ` i3c_master_add_i3c_dev_locked() accept PID, BCR, DCR Boris Brezillon
2018-12-10 20:14 ` Boris Brezillon
2018-12-11 11:54 ` vitor
2018-12-11 11:58 ` Boris Brezillon
2018-12-11 12:07 ` vitor
2018-12-11 12:21 ` Boris Brezillon
2018-12-11 12:25 ` Boris Brezillon
2018-12-11 15:47 ` vitor
2018-12-12 6:06 ` Przemyslaw Gaj
2018-12-12 8:21 ` Boris Brezillon
2018-12-12 8:37 ` Przemyslaw Gaj
2018-12-12 8:52 ` Boris Brezillon
2018-12-12 9:02 ` Przemyslaw Gaj
2018-12-12 9:09 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd731fb8-3b47-9364-baf7-da530bf9c786@synopsys.com \
--to=vitor.soares@synopsys.com \
--cc=linux-i3c@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox