[PATCH 0/2] i3c: remove redundant pm_runtime_dont_use_autosuspend() calls

[PATCH 0/2] i3c: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls.

Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
Joshua Crofts (2):
      i3c: dw: remove redundant pm_runtime_dont_use_autosuspend() calls
      i3c: master: svc: remove redundant pm_runtime_dont_use_autosuspend() calls

 drivers/i3c/master/dw-i3c-master.c  | 2 --
 drivers/i3c/master/svc-i3c-master.c | 2 --
 2 files changed, 4 deletions(-)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261107-dont-use-autosuspend-i3c-d05c16c18c80

Best regards,
-- 
Joshua Crofts


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

[PATCH 1/2] i3c: dw: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls.

Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
 drivers/i3c/master/dw-i3c-master.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index d1119f203d1b..f8fed797e0e4 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -1776,7 +1776,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
 		pm_runtime_put_noidle(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 	pm_runtime_set_suspended(&pdev->dev);
-	pm_runtime_dont_use_autosuspend(&pdev->dev);
 
 	return ret;
 }
@@ -1792,7 +1791,6 @@ void dw_i3c_common_remove(struct dw_i3c_master *master)
 
 	pm_runtime_disable(master->dev);
 	pm_runtime_set_suspended(master->dev);
-	pm_runtime_dont_use_autosuspend(master->dev);
 }
 EXPORT_SYMBOL_GPL(dw_i3c_common_remove);
 

-- 
2.56.0


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

[PATCH 2/2] i3c: master: svc: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.

Remove the redundant function calls.

Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
 drivers/i3c/master/svc-i3c-master.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index e700392f0801..9b845b2955be 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -2084,7 +2084,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
 	return 0;
 
 rpm_disable:
-	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	pm_runtime_put_noidle(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 	pm_runtime_set_suspended(&pdev->dev);
@@ -2101,7 +2100,6 @@ static void svc_i3c_master_remove(struct platform_device *pdev)
 
 	i3c_master_unregister(&master->base);
 
-	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 }
 

-- 
2.56.0


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

Re: [PATCH 1/2] i3c: dw: remove redundant pm_runtime_dont_use_autosuspend() calls

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [Medium] i3c: master: dw: clock enable count underflow in
  dw_i3c_common_remove() [1]
--

commit 4f7b7a8b26800680d2cdbe5fe6acbbf1f93c63ec
Author: Joshua Crofts <crofts@kernel.org>

i3c: dw: remove redundant pm_runtime_dont_use_autosuspend() calls

This commit removes redundant pm_runtime_dont_use_autosuspend() calls from
dw_i3c_common_probe() and dw_i3c_common_remove().

> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index d1119f203d1b6..f8fed797e0e4d 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c

[ ... ]

> @@ -1792,7 +1791,6 @@ void dw_i3c_common_remove(struct dw_i3c_master *master)
>  
>  	pm_runtime_disable(master->dev);
>  	pm_runtime_set_suspended(master->dev);
> -	pm_runtime_dont_use_autosuspend(master->dev);
>  }
>  EXPORT_SYMBOL_GPL(dw_i3c_common_remove);

[Severity: Medium]
This problem wasn't introduced by this patch, but can unbinding a
runtime-suspended controller underflow the clock enable counts [1]?

dw_i3c_common_probe() acquires core_clk and pclk via
devm_clk_get_optional_enabled(), which registers a devres action to call
clk_disable_unprepare() on removal.  However,
dw_i3c_master_runtime_suspend() also disables these clocks via
dw_i3c_master_disable_clks().  If the device is runtime-suspended when
dw_i3c_common_remove() disables runtime PM without resuming the device,
devres will disable the already-disabled clocks and trigger a clock
enable count underflow warning.

[1] https://sashiko.dev/#/bug/linux-2e78b07f-df35-42bd-b4ae-71873b79b67f

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107-dont-use-autosuspend-i3c-v1-0-80a1546354ce@kernel.org?part=1

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

Re: [PATCH 2/2] i3c: master: svc: remove redundant pm_runtime_dont_use_autosuspend() calls

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] i3c: master: svc: clock and pinctrl leak in
  svc_i3c_master_remove()
It also noticed 1 related pre-existing issue this patch does not
introduce:
- [Medium] i3c: master: svc: broken probe deferral in
  svc_i3c_master_probe() [1]
--

commit bd316ea905bc7cd25e557b9e7ceaaf86534b31c5
Author: Joshua Crofts <crofts@kernel.org>

i3c: master: svc: remove redundant pm_runtime_dont_use_autosuspend() calls

This commit removes pm_runtime_dont_use_autosuspend() calls from the probe
error path and remove callback in svc-i3c-master.

> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index e700392f0801f..9b845b2955be4 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -2084,7 +2084,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
>  	return 0;
>  
>  rpm_disable:
> -	pm_runtime_dont_use_autosuspend(&pdev->dev);
>  	pm_runtime_put_noidle(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  	pm_runtime_set_suspended(&pdev->dev);

[Severity: Medium]
This problem wasn't introduced by this patch, but earlier in
svc_i3c_master_probe() [1], does passing -EINVAL instead of
master->num_clks to dev_err_probe() break probe deferral?

drivers/i3c/master/svc-i3c-master.c:svc_i3c_master_probe() {
	...
	master->num_clks = devm_clk_bulk_get_all(dev, &master->clks);
	if (master->num_clks < 0)
		return dev_err_probe(dev, -EINVAL, "can't get I3C clocks\n");
	...
}

If the clock provider is not ready and devm_clk_bulk_get_all() returns
-EPROBE_DEFER, probe fails permanently with -EINVAL instead of deferring.

> @@ -2101,7 +2100,6 @@ static void svc_i3c_master_remove(struct platform_device *pdev)
>  
>  	i3c_master_unregister(&master->base);
>  
> -	pm_runtime_dont_use_autosuspend(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  }

[Severity: Medium]
Does removing pm_runtime_dont_use_autosuspend() here leave master->clks
prepared and enabled and pinctrl in the active state after driver removal?

i3c_master_unregister() calls i3c_master_bus_cleanup() ->
svc_i3c_master_bus_cleanup(), which wakes &pdev->dev via
pm_runtime_resume_and_get() and then calls pm_runtime_put_autosuspend().
Because autosuspend is enabled with a 1000 ms delay, that call only arms
the autosuspend timer and returns with &pdev->dev still active and
master->clks enabled.

Previously, calling pm_runtime_dont_use_autosuspend() before
pm_runtime_disable() caused the runtime PM core to synchronously run
svc_i3c_runtime_suspend(), which disables and unprepares master->clks and
selects the sleep pinctrl state:

drivers/i3c/master/svc-i3c-master.c:svc_i3c_runtime_suspend() {
	struct svc_i3c_master *master = dev_get_drvdata(dev);

	svc_i3c_save_regs(master);
	clk_bulk_disable_unprepare(master->num_clks, master->clks);
	pinctrl_pm_select_sleep_state(dev);

	return 0;
}

With pm_runtime_dont_use_autosuspend() removed, pm_runtime_disable()
cancels the pending autosuspend timer without running
svc_i3c_runtime_suspend(), and the later pm_runtime_reinit() in the driver
core runs after runtime PM is already disabled.

[1] https://sashiko.dev/#/bug/linux-7f6f30e6-7dc6-4272-b9a7-e0326db501a1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107-dont-use-autosuspend-i3c-v1-0-80a1546354ce@kernel.org?part=2

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

Re: [PATCH 2/2] i3c: master: svc: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

On Sat, 07 Nov 2026 12:06:24 +0100
Joshua Crofts <crofts@kernel.org> wrote:

> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
> 
> Remove the redundant function calls.
> 
> Signed-off-by: Joshua Crofts <crofts@kernel.org>
> ---
>  drivers/i3c/master/svc-i3c-master.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index e700392f0801..9b845b2955be 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -2084,7 +2084,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
>  	return 0;
>  
>  rpm_disable:
> -	pm_runtime_dont_use_autosuspend(&pdev->dev);
>  	pm_runtime_put_noidle(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  	pm_runtime_set_suspended(&pdev->dev);
> @@ -2101,7 +2100,6 @@ static void svc_i3c_master_remove(struct platform_device *pdev)
>  
>  	i3c_master_unregister(&master->base);
>  
> -	pm_runtime_dont_use_autosuspend(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  }
>  
> 

Okay, after reading Sashiko's review it seems that this patch won't
be as straight forward as I thought. I'm thinking of manually
suspending the device in the remove() function or just removing
dont_use_autosuspend() from the probe error path. Any thoughts?

--
Kind regards,
Joshua Crofts

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

Re: [PATCH 1/2] i3c: dw: remove redundant pm_runtime_dont_use_autosuspend() calls

[Frank Li]

On Sat, Nov 07, 2026 at 12:06:23PM +0100, Joshua Crofts wrote:
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
>
> Remove the redundant function calls.
>
> Signed-off-by: Joshua Crofts <crofts@kernel.org>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/i3c/master/dw-i3c-master.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index d1119f203d1b..f8fed797e0e4 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1776,7 +1776,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
>  		pm_runtime_put_noidle(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  	pm_runtime_set_suspended(&pdev->dev);
> -	pm_runtime_dont_use_autosuspend(&pdev->dev);
>
>  	return ret;
>  }
> @@ -1792,7 +1791,6 @@ void dw_i3c_common_remove(struct dw_i3c_master *master)
>
>  	pm_runtime_disable(master->dev);
>  	pm_runtime_set_suspended(master->dev);
> -	pm_runtime_dont_use_autosuspend(master->dev);
>  }
>  EXPORT_SYMBOL_GPL(dw_i3c_common_remove);
>
>
> --
> 2.56.0
>

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

Re: [PATCH 2/2] i3c: master: svc: remove redundant pm_runtime_dont_use_autosuspend() calls

[Frank Li]

On Sat, Nov 07, 2026 at 01:30:08PM +0100, Joshua Crofts wrote:
> On Sat, 07 Nov 2026 12:06:24 +0100
> Joshua Crofts <crofts@kernel.org> wrote:
>
> > Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> > driver core is now responsible for undoing any
> > pm_runtime_use_autosuspend() calls on driver exit.
> >
> > Remove the redundant function calls.
> >
> > Signed-off-by: Joshua Crofts <crofts@kernel.org>
> > ---
> >  drivers/i3c/master/svc-i3c-master.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> > index e700392f0801..9b845b2955be 100644
> > --- a/drivers/i3c/master/svc-i3c-master.c
> > +++ b/drivers/i3c/master/svc-i3c-master.c
> > @@ -2084,7 +2084,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
> >  	return 0;
> >
> >  rpm_disable:
> > -	pm_runtime_dont_use_autosuspend(&pdev->dev);
> >  	pm_runtime_put_noidle(&pdev->dev);
> >  	pm_runtime_disable(&pdev->dev);
> >  	pm_runtime_set_suspended(&pdev->dev);
> > @@ -2101,7 +2100,6 @@ static void svc_i3c_master_remove(struct platform_device *pdev)
> >
> >  	i3c_master_unregister(&master->base);
> >
> > -	pm_runtime_dont_use_autosuspend(&pdev->dev);
> >  	pm_runtime_disable(&pdev->dev);
> >  }
> >
> >
>
> Okay, after reading Sashiko's review it seems that this patch won't
> be as straight forward as I thought. I'm thinking of manually
> suspending the device in the remove() function or just removing
> dont_use_autosuspend() from the probe error path. Any thoughts?

Just leave it as it now. I will fix it later.

Frank

>
> --
> Kind regards,
> Joshua Crofts

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

Re: [PATCH 2/2] i3c: master: svc: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

On Wed, 11 Nov 2026 14:43:33 -0500
Frank Li <Frank.li@oss.nxp.com> wrote:

> On Sat, Nov 07, 2026 at 01:30:08PM +0100, Joshua Crofts wrote:
> > On Sat, 07 Nov 2026 12:06:24 +0100
> > Joshua Crofts <crofts@kernel.org> wrote:
> >  
> > > Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> > > driver core is now responsible for undoing any
> > > pm_runtime_use_autosuspend() calls on driver exit.
> > >
> > > Remove the redundant function calls.
> > >
> > > Signed-off-by: Joshua Crofts <crofts@kernel.org>
> > > ---
> > >  drivers/i3c/master/svc-i3c-master.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> > > index e700392f0801..9b845b2955be 100644
> > > --- a/drivers/i3c/master/svc-i3c-master.c
> > > +++ b/drivers/i3c/master/svc-i3c-master.c
> > > @@ -2084,7 +2084,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
> > >  	return 0;
> > >
> > >  rpm_disable:
> > > -	pm_runtime_dont_use_autosuspend(&pdev->dev);
> > >  	pm_runtime_put_noidle(&pdev->dev);
> > >  	pm_runtime_disable(&pdev->dev);
> > >  	pm_runtime_set_suspended(&pdev->dev);
> > > @@ -2101,7 +2100,6 @@ static void svc_i3c_master_remove(struct platform_device *pdev)
> > >
> > >  	i3c_master_unregister(&master->base);
> > >
> > > -	pm_runtime_dont_use_autosuspend(&pdev->dev);
> > >  	pm_runtime_disable(&pdev->dev);
> > >  }
> > >
> > >  
> >
> > Okay, after reading Sashiko's review it seems that this patch won't
> > be as straight forward as I thought. I'm thinking of manually
> > suspending the device in the remove() function or just removing
> > dont_use_autosuspend() from the probe error path. Any thoughts?  
> 
> Just leave it as it now. I will fix it later.

Cool. Thanks Frank!

-- 
Kind regards,
Joshua Crofts

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c