public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: "JWM" <jwm@systemfabricworks.com>
To: linux-ia64@vger.kernel.org
Subject: Re: Spinlock bug??
Date: Thu, 25 Jan 2007 21:49:10 +0000	[thread overview]
Message-ID: <001d01c740ca$a5fe0cd0$7401a8c0@Maelstrom> (raw)
In-Reply-To: <003e01c73fd8$6a46f730$7401a8c0@Maelstrom>

    Simon;
    I've looked at the code and the function that calls 
cpuset_set_cpus_affinity does a get_task. That bumps the usage count and 
should protect from an exiting process doing evil - shouldn't it?
    So the sched_setaffinity locks, bumps the task useage and then unlocks 
and calls cpuset_set_cpus_affinity. The in the Bull code 
cpuset_set_cpuaffinity takes a spin lock on the structure and then 
(potentially) moves it to another CPU.
    It doesn't look like a change is required other than removing the lock 
in cpuset_set_cpus_affinity.
    Is there a possible race here I'm missing?
    ....JW
----- Original Message ----- 
From: "Simon Derr" <Simon.Derr@bull.net>
To: "JWM" <jwm@systemfabricworks.com>
Cc: <linux-ia64@vger.kernel.org>; "Philippe Garrigues" 
<philippe.garrigues@bull.net>
Sent: Thursday, January 25, 2007 3:12 AM
Subject: Re: Spinlock bug??


>>    Hi all;
>>    I'm working on a Bull - 8 way ia64 system running a RedHat variant of
>> 2.6.17.
>>    I keep getting a spin lock bug and dump , attached.
>
> Hello,
>
> If you are running a Bull Linux kernel, I suggest that you contact
> directly Bull for this kind of issues. We have added a few custom patches
> that could hardly be adressed by other people from this list.
>
> That being said, I'm going to see what's going on in this particular case.
> You're probably right.
>
> Simon.
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


  parent reply	other threads:[~2007-01-25 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-24 16:55 Spinlock bug?? JWM
2007-01-25  9:12 ` Simon Derr
2007-01-25 17:39 ` Christoph Lameter
2007-01-25 21:49 ` JWM [this message]
2007-01-25 21:51 ` JWM

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001d01c740ca$a5fe0cd0$7401a8c0@Maelstrom' \
    --to=jwm@systemfabricworks.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox