[RFC IA64 Hotplug] [Patch 3/7] sysfs_ia64.patch

[RFC IA64 Hotplug] [Patch 3/7] sysfs_ia64.patch

[Ashok Raj]

Patch 3/7

Cheers,
ashok raj
- Linux Core Software Group
   

Name: sysfs_ia64.patch
Author: Ashok Raj (Intel Corporation)
D: Creation of sysfs via topology_init() creates sysfs entries. The creation
of
D: the online control file is created separately when the cpu_up is invoked
D: in arch independent code.
---



---

 linux-2.6.5-lhcs-root/arch/ia64/dig/Makefile   |    2 -
 linux-2.6.5-lhcs-root/arch/ia64/dig/topology.c |   43
+++++++++++++++++++++++++
 linux-2.6.5-lhcs-root/include/asm-ia64/cpu.h   |   17 +++++++++
 3 files changed, 61 insertions(+), 1 deletion(-)

diff -puN arch/ia64/dig/Makefile~sysfs_ia64 arch/ia64/dig/Makefile
--- linux-2.6.5-lhcs/arch/ia64/dig/Makefile~sysfs_ia64	2004-04-20
21:08:16.000000000 -0700
+++ linux-2.6.5-lhcs-root/arch/ia64/dig/Makefile	2004-04-20
21:08:16.000000000 -0700
@@ -5,5 +5,5 @@
 # Copyright (C) Srinivasa Thirumalachar (sprasad@engr.sgi.com)
 #
 
-obj-y := setup.o
+obj-y := setup.o topology.o
 obj-$(CONFIG_IA64_GENERIC) += machvec.o
diff -puN /dev/null arch/ia64/dig/topology.c
--- /dev/null	2003-09-15 06:02:17.000000000 -0700
+++ linux-2.6.5-lhcs-root/arch/ia64/dig/topology.c	2004-04-23
23:10:50.559191141 -0700
@@ -0,0 +1,43 @@
+/*
+ * arch/ia64/dig/topology.c
+ *	Popuate driverfs with topology information.
+ *	Derived entirely from i386/mach-default.c
+ *  Intel Corporation - Ashok Raj
+ */
+#include <linux/init.h>
+#include <linux/smp.h>
+#include <linux/cpumask.h>
+#include <linux/percpu.h>
+#include <linux/notifier.h>
+#include <linux/cpu.h>
+#include <asm/cpu.h>
+
+static DEFINE_PER_CPU(struct ia64_cpu, cpu_devices);
+
+/*
+ * First Pass: simply borrowed code for now. Later should hook into
+ * hotplug notification for node/cpu/memory as applicable
+ */
+
+static int arch_register_cpu(int num)
+{
+	struct node *parent = NULL;
+
+#ifdef CONFIG_NUMA
+	//parent = &node_devices[cpu_to_node(num)].node;
+#endif
+
+	return register_cpu(&per_cpu(cpu_devices,num).cpu, num, parent);
+}
+
+static int __init topology_init(void)
+{
+    int i;
+
+    for_each_cpu(i) {
+        arch_register_cpu(i);
+	}
+    return 0;
+}
+
+subsys_initcall(topology_init);
diff -puN /dev/null include/asm-ia64/cpu.h
--- /dev/null	2003-09-15 06:02:17.000000000 -0700
+++ linux-2.6.5-lhcs-root/include/asm-ia64/cpu.h	2004-04-20
21:13:47.000000000 -0700
@@ -0,0 +1,17 @@
+#ifndef _ASM_IA64_CPU_H_
+#define _ASM_IA64_CPU_H_
+
+#include <linux/device.h>
+#include <linux/cpu.h>
+#include <linux/topology.h>
+#include <linux/percpu.h>
+
+struct ia64_cpu {
+	struct cpu cpu;
+};
+
+DECLARE_PER_CPU(struct ia64_cpu, cpu_devices);
+
+DECLARE_PER_CPU(int, cpu_state);
+
+#endif /* _ASM_IA64_CPU_H_ */

_

Re: [RFC IA64 Hotplug] [Patch 3/7] sysfs_ia64.patch

[David Mosberger]

>>>>> On Sat, 24 Apr 2004 23:46:34 -0700, "Ashok Raj" <ashok.raj@intel.com> said:

  Ashok> +static DEFINE_PER_CPU(struct ia64_cpu, cpu_devices);

This seems to be ~100 bytes per CPU.  With 128 CPUs, that's ~13KB out
of a max of 64KB.  Just a heads up...

	--david

Re: [RFC IA64 Hotplug] [Patch 3/7] sysfs_ia64.patch

[Rusty Russell]

On Tue, 2004-04-27 at 08:03, David Mosberger wrote:
> >>>>> On Sat, 24 Apr 2004 23:46:34 -0700, "Ashok Raj" <ashok.raj@intel.com> said:
> 
>   Ashok> +static DEFINE_PER_CPU(struct ia64_cpu, cpu_devices);
> 
> This seems to be ~100 bytes per CPU.  With 128 CPUs, that's ~13KB out
> of a max of 64KB.  Just a heads up...

David, you had me going there for a while.

It's 100 bytes out of 64k, because there's 64k per-cpu, right?

Thanks,
Rusty.
-- 
Anyone who quotes me in their signature is an idiot -- Rusty Russell

Re: [RFC IA64 Hotplug] [Patch 3/7] sysfs_ia64.patch

[David Mosberger]

>>>>> On Tue, 27 Apr 2004 10:20:55 +1000, Rusty Russell <rusty@rustcorp.com.au> said:

  Rusty> On Tue, 2004-04-27 at 08:03, David Mosberger wrote:
  >> >>>>> On Sat, 24 Apr 2004 23:46:34 -0700, "Ashok Raj"
  >> <ashok.raj@intel.com> said:

  Ashok> +static DEFINE_PER_CPU(struct ia64_cpu, cpu_devices);
  >>  This seems to be ~100 bytes per CPU.  With 128 CPUs, that's
  >> ~13KB out of a max of 64KB.  Just a heads up...

  Rusty> David, you had me going there for a while.

  Rusty> It's 100 bytes out of 64k, because there's 64k per-cpu,
  Rusty> right?

Duh.  It's Monday, what can i say! ;-)

	--david