* [PATCH] incorrect return from ia64_pci_legacy_write()
@ 2005-12-21 22:21 Alex Williamson
0 siblings, 0 replies; only message in thread
From: Alex Williamson @ 2005-12-21 22:21 UTC (permalink / raw)
To: linux-ia64
Tony,
Maybe there's time for one more push to Linus? The function
ia64_pci_legacy_write() returns 0 for everything except errors. This
return value gets sent back to the user from pci_write_legacy_io(),
making it look like every write fails. The trivial patch below copies
the behavior of the SGI sn machvec and does what would be expected from
something implementing a write() function. Please apply, Thanks,
Alex
Signed-off-by: Alex Williamson <alex.williamson@hp.com>
---
diff -r 513446906e2e arch/ia64/pci/pci.c
--- a/arch/ia64/pci/pci.c Wed Dec 21 19:05:15 2005
+++ b/arch/ia64/pci/pci.c Wed Dec 21 14:52:44 2005
@@ -700,7 +700,7 @@
*/
int ia64_pci_legacy_write(struct pci_dev *bus, u16 port, u32 val, u8 size)
{
- int ret = 0;
+ int ret = size;
switch (size) {
case 1:
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-12-21 22:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-21 22:21 [PATCH] incorrect return from ia64_pci_legacy_write() Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox