From: David Woodhouse <dwmw2@infradead.org>
To: linux-ia64@vger.kernel.org
Subject: Re: + git-hdrcleanup-vs-git-klibc-on-ia64-2.patch added to -mm tree
Date: Sun, 14 May 2006 21:37:42 +0000 [thread overview]
Message-ID: <1147642663.2729.8.camel@shinybook.infradead.org> (raw)
In-Reply-To: <1147633985.2551.14.camel@shinybook.infradead.org>
On Sun, 2006-05-14 at 23:13 +0200, Andreas Schwab wrote:
> > Hm, same applies here as to the last one. The __KERNEL__ ifdef applies
> > to the whole crap around PAGE_SHIFT _and_ PAGE_SIZE, at least.
>
> Userspace should be using getpagesize() anyway.
Yes. That's why I say all the PAGE_SIZE crap should be in #ifdef
__KERNEL__.
I also suspect a lot of the _rest_ of that file shouldn't be visible
either. What's in there that we actually _need_ to export?
--
dwmw2
next prev parent reply other threads:[~2006-05-14 21:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-14 19:13 + git-hdrcleanup-vs-git-klibc-on-ia64-2.patch added to -mm tree David Woodhouse
2006-05-14 21:13 ` Andreas Schwab
2006-05-14 21:17 ` Christoph Hellwig
2006-05-14 21:37 ` David Woodhouse [this message]
2006-05-14 22:03 ` H. Peter Anvin
2006-05-14 22:05 ` H. Peter Anvin
2006-05-14 22:11 ` David Woodhouse
2006-05-14 22:34 ` H. Peter Anvin
2006-05-14 22:41 ` David Woodhouse
2006-05-14 23:22 ` H. Peter Anvin
2006-05-14 23:35 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147642663.2729.8.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox