Re: + git-hdrcleanup-vs-git-klibc-on-ia64-2.patch added to -mm tree

[Andreas Schwab <schwab@suse.de>]

David Woodhouse <dwmw2@infradead.org> writes:

> On Sun, 2006-05-14 at 11:01 -0700, akpm@osdl.org wrote:
>> 
>> diff -puN include/asm-ia64/page.h~git-hdrcleanup-vs-git-klibc-on-ia64-2 include/asm-ia64/page.h
>> --- 25/include/asm-ia64/page.h~git-hdrcleanup-vs-git-klibc-on-ia64-2    Mon May 15 01:48:22 2006
>> +++ 25-akpm/include/asm-ia64/page.h     Mon May 15 01:49:38 2006
>> @@ -36,7 +36,11 @@
>>  #elif defined(CONFIG_IA64_PAGE_SIZE_64KB)
>>  # define PAGE_SHIFT    16
>>  #else
>> +#ifdef __KERNEL__
>>  # error Unsupported page size!
>> +#else
>> +#define PAGE_SHIFT     12
>> +#endif
>>  #endif
>>  
>>  #define PAGE_SIZE              (__IA64_UL_CONST(1) << PAGE_SHIFT)
>
> Hm, same applies here as to the last one. The __KERNEL__ ifdef applies
> to the whole crap around PAGE_SHIFT _and_ PAGE_SIZE, at least. 

Userspace should be using getpagesize() anyway.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."