From: Alex Williamson <alex.williamson@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: Disparity between esi.c & esi.h
Date: Mon, 15 Jan 2007 15:44:29 +0000 [thread overview]
Message-ID: <1168875869.14363.350.camel@bling> (raw)
In-Reply-To: <5e0a1fd80701150147i666f76dp9292a77d1fa9d3cf@mail.gmail.com>
On Mon, 2007-01-15 at 15:17 +0530, Karthik Gopalakrishnan wrote:
> Hi Folks.
>
> esi.h has the following extern with no corresponding definition in esi.c
> extern int ia64_esi_init (void);
>
> The closest definition in esi.c is the following:
> static int __init esi_init (void)
> {
> ...
> }
>
> Is this an oversight or am I missing something? I am looking at the
> 2.6.19 sources.
Hi Karthik,
I had an ia64_esi_init() in a previous version of this patch. Looks
like it accidentally made it's way to the final version even though the
function became esi_init(), which doesn't need a prototype. Thanks for
spotting this.
Alex
--
Alex Williamson HP Open Source & Linux Org.
prev parent reply other threads:[~2007-01-15 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-15 9:59 Disparity between esi.c & esi.h Karthik Gopalakrishnan
2007-01-15 15:44 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1168875869.14363.350.camel@bling \
--to=alex.williamson@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox