public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
* Disparity between esi.c & esi.h
@ 2007-01-15  9:59 Karthik Gopalakrishnan
  2007-01-15 15:44 ` Alex Williamson
  0 siblings, 1 reply; 2+ messages in thread
From: Karthik Gopalakrishnan @ 2007-01-15  9:59 UTC (permalink / raw)
  To: linux-ia64

Hi Folks.

esi.h has the following extern with no corresponding definition in esi.c
extern int ia64_esi_init (void);

The closest definition in esi.c is the following:
static int __init esi_init (void)
{
...
}

Is this an oversight or am I missing something? I am looking at the
2.6.19 sources.

Thanks & Regards,
Karthik

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Disparity between esi.c & esi.h
  2007-01-15  9:59 Disparity between esi.c & esi.h Karthik Gopalakrishnan
@ 2007-01-15 15:44 ` Alex Williamson
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2007-01-15 15:44 UTC (permalink / raw)
  To: linux-ia64

On Mon, 2007-01-15 at 15:17 +0530, Karthik Gopalakrishnan wrote:
> Hi Folks.
> 
> esi.h has the following extern with no corresponding definition in esi.c
> extern int ia64_esi_init (void);
> 
> The closest definition in esi.c is the following:
> static int __init esi_init (void)
> {
> ...
> }
> 
> Is this an oversight or am I missing something? I am looking at the
> 2.6.19 sources.

Hi Karthik,

   I had an ia64_esi_init() in a previous version of this patch.  Looks
like it accidentally made it's way to the final version even though the
function became esi_init(), which doesn't need a prototype.  Thanks for
spotting this.

	Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-01-15 15:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-15  9:59 Disparity between esi.c & esi.h Karthik Gopalakrishnan
2007-01-15 15:44 ` Alex Williamson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox