[PATCH] ia64: Include <linux/personality.h> header in <asm/fcntl.h>

[PATCH] ia64: Include <linux/personality.h> header in <asm/fcntl.h>

[Ben Hutchings]

The definition of force_o_largefile() references personality, but this
header does not include <linux/personality.h>.  This happens to work
for sys_open(), but may not for any other users.  In particular, aufs2
now uses this macro and so fails to build on ia64.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 arch/ia64/include/asm/fcntl.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/ia64/include/asm/fcntl.h b/arch/ia64/include/asm/fcntl.h
index 1dd275d..3cac8f9 100644
--- a/arch/ia64/include/asm/fcntl.h
+++ b/arch/ia64/include/asm/fcntl.h
@@ -5,6 +5,8 @@
  *	David Mosberger-Tang <davidm@hpl.hp.com>, Hewlett-Packard Co.
  */
 
+#include <linux/personality.h>
+
 #define force_o_largefile()	\
 		(personality(current->personality) != PER_LINUX32)
 
-- 
1.6.5.7

Re: [PATCH] ia64: Include <linux/personality.h> header in

[Christoph Hellwig]

On Sat, Dec 19, 2009 at 04:25:43PM +0000, Ben Hutchings wrote:
> The definition of force_o_largefile() references personality, but this
> header does not include <linux/personality.h>.  This happens to work
> for sys_open(), but may not for any other users.  In particular, aufs2
> now uses this macro and so fails to build on ia64.

So include the header there directly.  Or rather don't use it at all,
filesystems have no business at all messing with this.