From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] ISA stubs for ia64
Date: Tue, 06 Apr 2004 23:18:50 +0000 [thread overview]
Message-ID: <16499.15066.967913.431674@napali.hpl.hp.com> (raw)
In-Reply-To: <200404061630.20264.bjorn.helgaas@hp.com>
>>>>> On Tue, 6 Apr 2004 16:30:20 -0600, Bjorn Helgaas <bjorn.helgaas@hp.com> said:
Bjorn> These stubs allow us to build all the old drivers that assume
Bjorn> ISA is present. (Many of these support both ISA and PCI
Bjorn> adapters, so we do actually want them.)
Bjorn> With this patch and the others I just posted (hw_random,
Bjorn> simscsi, gen_rtc), we can build allmodconfig on ia64.
I don't like this patch at all. The #defines to
unsupported_isa_dma_interface() turn compile-time errors into
potential runtime errors. With a properly abstracted interface, the
ISA-compatibility-macros should not lead to any code in ISA-free
systems (and hence there would be no possibility of runtime errors).
--david
next prev parent reply other threads:[~2004-04-06 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-06 22:30 [PATCH] ISA stubs for ia64 Bjorn Helgaas
2004-04-06 23:18 ` David Mosberger [this message]
2004-04-07 15:09 ` Bjorn Helgaas
2004-04-07 17:42 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16499.15066.967913.431674@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox