[PATCH] __ARCH_WANT_SYS_SIGPROCMASK

[PATCH] __ARCH_WANT_SYS_SIGPROCMASK

[Jason Baron]

hi,

The __ARCH_WANT_SYS_SIGPROCMASK #ifdef wraps the definition of both
sys_sigprocmask as well as sys_rt_sigaction. I think it should probably
only include the former. In any case, if CONFIG_IA32_SUPPORT is not set
the build can't find the sys_rt_sigaction symbol as
__ARCH_WANT_SYS_SIGPROCMASK is not definied in this case. The patch below,
makes the #ifdef only apply to sys_sigprocmask. I've verfied that this
patch does not break x86, ppc, x86_64, and of course fixes ia64 builds
when CONFIG_IA32_SUPPORT is not set.

thanks,

-Jason

--- linux-2.6.6/kernel/signal.c.bak	Wed Jun  2 17:49:14 2004
+++ linux-2.6.6/kernel/signal.c	Wed Jun  2 17:49:45 2004
@@ -2512,6 +2512,8 @@ out:
 	return error;
 }
 
+#endif /* SIGPROCMASK */
+
 #ifndef __sparc__
 asmlinkage long
 sys_rt_sigaction(int sig,
@@ -2541,7 +2543,6 @@ out:
 	return ret;
 }
 #endif /* __sparc__ */
-#endif
 
 #ifdef __ARCH_WANT_SYS_SGETMASK
 

Re: [PATCH] __ARCH_WANT_SYS_SIGPROCMASK

[David Mosberger]

Hi Jason,

>>>>> On Thu, 3 Jun 2004 08:17:43 -0400 (EDT), Jason Baron <jbaron@redhat.com> said:

  Jason> The __ARCH_WANT_SYS_SIGPROCMASK #ifdef wraps the definition
  Jason> of both sys_sigprocmask as well as sys_rt_sigaction. I think
  Jason> it should probably only include the former. In any case, if
  Jason> CONFIG_IA32_SUPPORT is not set the build can't find the
  Jason> sys_rt_sigaction symbol as __ARCH_WANT_SYS_SIGPROCMASK is not
  Jason> definied in this case. The patch below, makes the #ifdef only
  Jason> apply to sys_sigprocmask. I've verfied that this patch does
  Jason> not break x86, ppc, x86_64, and of course fixes ia64 builds
  Jason> when CONFIG_IA32_SUPPORT is not set.

Darren Williams reported the same bug a few days ago on linux-ia64.
The patch is in my tree and just today hit Linus' tree (via Andrew),
so it should be all good now.

Thanks,

	--david