public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: strict rejection of init -> core references causes problems
Date: Fri, 09 Jul 2004 07:02:26 +0000	[thread overview]
Message-ID: <16622.17154.117052.31601@napali.hpl.hp.com> (raw)

Tony,

The recent patch of yours to the kernel module loader is causing some
problems with the netfilter modules.  To recap, with that patch
applied, calls from the core section of a module to an init section
are rejected because that's in general a dangerous thing to do (the
called code may be gone by the time the call gets executed).

I'm not terribly familiar with the netfilter code, but I think the
problem there comes from the fact that some code is shared between
init and exit handlers and that shared code ends up in the module
core.

For example, ip_nat_standalone.c:init_or_cleanup() may call
ip_nat_rule_init(), which is marked as an __init function.  This
happens to be safe because ip_nat_rule_init() is only called during
module-initialization.  Seems to me like a dangerous practice, but if
it's common practice, I suppose we don't have much choice but to allow
calls from core to init sections again.  Perhaps someone from the
netfilter team could comment?

	--david

             reply	other threads:[~2004-07-09  7:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-09  7:02 David Mosberger [this message]
2004-07-09  8:01 ` [netfilter-core] strict rejection of init -> core references causes problems Harald Welte
2004-07-09 15:59 ` Luck, Tony
2004-07-09 18:36 ` [netfilter-core] " David Mosberger
2004-07-09 18:46 ` Luck, Tony
2004-07-09 18:52 ` [netfilter-core] " Harald Welte
2004-07-09 19:19 ` Luck, Tony
2004-07-10  7:15 ` Harald Welte
2004-07-12 14:36 ` [netfilter-core] strict rejection of init -> core references Jean-Marc Saffroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16622.17154.117052.31601@napali.hpl.hp.com \
    --to=davidm@napali.hpl.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox