public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Harald Welte <laforge@netfilter.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [netfilter-core] strict rejection of init -> core references causes problems
Date: Fri, 09 Jul 2004 18:52:37 +0000	[thread overview]
Message-ID: <20040709185237.GF5173@sunbeam2> (raw)
In-Reply-To: <16622.17154.117052.31601@napali.hpl.hp.com>

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

On Fri, Jul 09, 2004 at 11:36:35AM -0700, David Mosberger wrote:

> We don't have much of a choice, but I think it would be worthwhile to
> consider whether netfilter could avoid doing this in the future.  It
> really is very easy to make a mistake when allowing core->init calls.

well, all we do is:

1) have a common init and de-init function
2) call it from a wrapper funcion declared as module_init()
3) call it from a wrapper function declared __exit as module_exit()

Since 1) is called from init and fini, we cannot declare it as __init
(this would remove it from ram).

So what really happens is: calls from init to 'core' functions and calls
from 'exit' to core functions.

> 	--david

-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2004-07-09 18:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-09  7:02 strict rejection of init -> core references causes problems David Mosberger
2004-07-09  8:01 ` [netfilter-core] " Harald Welte
2004-07-09 15:59 ` Luck, Tony
2004-07-09 18:36 ` [netfilter-core] " David Mosberger
2004-07-09 18:46 ` Luck, Tony
2004-07-09 18:52 ` Harald Welte [this message]
2004-07-09 19:19 ` [netfilter-core] " Luck, Tony
2004-07-10  7:15 ` Harald Welte
2004-07-12 14:36 ` [netfilter-core] strict rejection of init -> core references Jean-Marc Saffroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040709185237.GF5173@sunbeam2 \
    --to=laforge@netfilter.org \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox