From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] fix phys. address conversion in ia64_pal_tr_read
Date: Tue, 16 Nov 2004 17:57:55 +0000 [thread overview]
Message-ID: <16794.16291.3350.872336@napali.hpl.hp.com> (raw)
In-Reply-To: <200411151722.41157.jbarnes@engr.sgi.com>
>>>>> On Tue, 16 Nov 2004 09:01:49 -0800, Jesse Barnes <jbarnes@engr.sgi.com> said:
Jesse> On Monday, November 15, 2004 6:03 pm, David Mosberger wrote:
>> >>>>> On Mon, 15 Nov 2004 17:22:41 -0800, Jesse Barnes >>>>>
>> <jbarnes@engr.sgi.com> said:
Jesse> The palinfo module may call ia64_pal_tr_read using an IPI.
Jesse> If the processor receiving the IPI is idle, the call will
Jesse> fail since the idle process stack is in region 5 and
Jesse> ia64_pal_tr_read uses __pa rather than ia64_tpa. This small
Jesse> patch fixes the problem by making it use ia64_tpa instead.
>> Perhaps its worthwhile to do any audit for this kind of
>> problems? It may not be very difficult to hack sparse to add a
>> check for __pa() calls on (stack-)local variables.
Jesse> I didn't see anything obvious in a quick check of all the
Jesse> ia64 users of __pa (they were mostly referring to stuff in
Jesse> the static data section), but I may have missed something.
OK, thanks for looking!
--david
prev parent reply other threads:[~2004-11-16 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 1:22 [PATCH] fix phys. address conversion in ia64_pal_tr_read Jesse Barnes
2004-11-16 2:03 ` David Mosberger
2004-11-16 17:01 ` Jesse Barnes
2004-11-16 17:57 ` David Mosberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16794.16291.3350.872336@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox