[PATCH 5/5] Itanium MC Error Injection Tool: pal_mc_error_inject() interface

[PATCH 5/5] Itanium MC Error Injection Tool: pal_mc_error_inject() interface

[Fenghua Yu]

This patch implements pal_mc_error_inject() interface in kernel. Both physical
mode and virtual mode are supported.

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>

--- a/include/asm-ia64/pal.h	2006-12-05 18:10:35.000000000 -0800
+++ b/include/asm-ia64/pal.h	2006-12-05 18:11:12.000000000 -0800
@@ -80,6 +80,8 @@
 #define PAL_SET_PSTATE		263	/* set the P-state */
 #define PAL_BRAND_INFO		274	/* Processor branding information */
 
+#define PAL_MC_ERROR_INJECT	276	/* Injects processor error or returns injection capabilities */
+
 #ifndef __ASSEMBLY__
 
 #include <linux/types.h>
@@ -1200,6 +1202,37 @@ ia64_pal_mc_error_info (u64 info_index, 
 	return iprv.status;
 }
 
+/* Injects the requested processor error or returns info on
+ * supported injection capabilities for current processor implementation
+ */
+static inline s64
+ia64_pal_mc_error_inject_phys (u64 err_type_info, u64 err_struct_info,
+			u64 err_data_buffer, u64 *capabilities, u64 *resources)
+{
+	struct ia64_pal_retval iprv;
+	PAL_CALL_PHYS_STK(iprv, PAL_MC_ERROR_INJECT, err_type_info,
+			  err_struct_info, err_data_buffer);
+	if (capabilities)
+		*capabilities= iprv.v0;
+	if (resources)
+		*resources= iprv.v1;
+	return iprv.status;
+}
+
+static inline s64
+ia64_pal_mc_error_inject_virt (u64 err_type_info, u64 err_struct_info,
+			u64 err_data_buffer, u64 *capabilities, u64 *resources)
+{
+	struct ia64_pal_retval iprv;
+	PAL_CALL_STK(iprv, PAL_MC_ERROR_INJECT, err_type_info,
+			  err_struct_info, err_data_buffer);
+	if (capabilities)
+		*capabilities= iprv.v0;
+	if (resources)
+		*resources= iprv.v1;
+	return iprv.status;
+}
+
 /* Inform PALE_CHECK whether a machine check is expected so that PALE_CHECK willnot
  * attempt to correct any expected machine checks.
  */

Re: [PATCH 5/5] Itanium MC Error Injection Tool: pal_mc_error_inject() interface

[Keith Owens]

Fenghua Yu (on Fri, 8 Dec 2006 16:17:31 -0800) wrote:
>This patch implements pal_mc_error_inject() interface in kernel. Both physical
>mode and virtual mode are supported.
>
>Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
>
>--- a/include/asm-ia64/pal.h	2006-12-05 18:10:35.000000000 -0800
>+++ b/include/asm-ia64/pal.h	2006-12-05 18:11:12.000000000 -0800
>@@ -80,6 +80,8 @@
> #define PAL_SET_PSTATE		263	/* set the P-state */
> #define PAL_BRAND_INFO		274	/* Processor branding information */
> 
>+#define PAL_MC_ERROR_INJECT	276	/* Injects processor error or returns injection capabilities */

Does this need a particular version of PAL?

Re: [PATCH 5/5] Itanium MC Error Injection Tool: pal_mc_error_inject() interface

[Fenghua Yu]

On Mon, Dec 11, 2006 at 10:02:52AM +1100, Keith Owens wrote:
> > 
> >+#define PAL_MC_ERROR_INJECT	276	/* Injects processor error or returns injection capabilities */
> 
> Does this need a particular version of PAL?
Yes, the latest Montecito PAL supports this feature. Please note because of errata in PAL, some errors
can not be injected correctly. Please see patch [2/5] for tested working errors.

Re: [PATCH 5/5] Itanium MC Error Injection Tool: pal_mc_error_inject() interface

[Russ Anderson]

Fenghua Yu wrote:
> On Mon, Dec 11, 2006 at 10:02:52AM +1100, Keith Owens wrote:
> > > 
> > >+#define PAL_MC_ERROR_INJECT	276	/* Injects processor error or returns injection capabilities */
> > 
> > Does this need a particular version of PAL?
>
> Yes, the latest Montecito PAL supports this feature.

I assume you mean PAL 8.30.  

>  Please note because of errata in PAL, some errors
> can not be injected correctly. Please see patch [2/5] for tested working errors.

The easy way to tell is the -q (query) option.

On Madison:

piton:~/rja.2619-5 # ./err_injection_tool -q
All capabilities implemented in pal_mc_error_inject:
No capabilities supported.

On Montecito:

cobra:~/rja.2619-5 # ./err_injection_tool -q
All capabilities implemented in pal_mc_error_inject:
For err_sev=0, err_struct=1, struct_hier=2: capabilities 0x100001c12
For err_sev=0, err_struct=1, struct_hier=3: capabilities 0x100001c12
For err_sev=1, err_struct=1, struct_hier=2: capabilities 0x100001c12
For err_sev=1, err_struct=2, struct_hier=2: capabilities 0x100000013
For err_sev=1, err_struct=3, struct_hier=1: capabilities 0x100010007
For err_sev=2, err_struct=1, struct_hier=2: capabilities 0x100001c0a


-- 
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          rja@sgi.com

Re: [PATCH 5/5] Itanium MC Error Injection Tool: pal_mc_error_inject() interface

[Fenghua Yu]

On Mon, Dec 11, 2006 at 01:44:44PM -0600, Russ Anderson wrote:
> Fenghua Yu wrote:
> > On Mon, Dec 11, 2006 at 10:02:52AM +1100, Keith Owens wrote:
> > > > 
> > > >+#define PAL_MC_ERROR_INJECT	276	/* Injects processor error or returns injection capabilities */
> > > 
> > > Does this need a particular version of PAL?
> >
> > Yes, the latest Montecito PAL supports this feature.
> 
> I assume you mean PAL 8.30.  
Yes.

> 
> >  Please note because of errata in PAL, some errors
> > can not be injected correctly. Please see patch [2/5] for tested working errors.
> 
> The easy way to tell is the -q (query) option.
> 
> On Madison:
> 
> piton:~/rja.2619-5 # ./err_injection_tool -q
> All capabilities implemented in pal_mc_error_inject:
> No capabilities supported.
> 
> On Montecito:
> 
> cobra:~/rja.2619-5 # ./err_injection_tool -q
> All capabilities implemented in pal_mc_error_inject:
> For err_sev=0, err_struct=1, struct_hier=2: capabilities 0x100001c12
> For err_sev=0, err_struct=1, struct_hier=3: capabilities 0x100001c12
> For err_sev=1, err_struct=1, struct_hier=2: capabilities 0x100001c12
> For err_sev=1, err_struct=2, struct_hier=2: capabilities 0x100000013
> For err_sev=1, err_struct=3, struct_hier=1: capabilities 0x100010007
> For err_sev=2, err_struct=1, struct_hier=2: capabilities 0x100001c0a
> 
> 
This is good way to actually check the capabilities. But still please note one reported capability might be buggy in PAL.