From: Andrew Morton <akpm@osdl.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Updating our sn code in 2.6] - Patch 028
Date: Sat, 10 Jan 2004 07:46:08 +0000 [thread overview]
Message-ID: <20040109234608.18009a2a.akpm@osdl.org> (raw)
Paul Jackson <pj@sgi.com> wrote:
>
> Rusty, responding to Andrew, on a cpumask failure seen by Jesse:
> > Probably. Paul Jackson acked them though, so I'm a little surprised.
>
> Jesse or Rusty - could you send me the earlier parts of this
> email thread? I don't see it on lkml or ia64 email list.
>
> I'd like to see what I missed in Rusty's patch.
>
> Though I am less surprised than Rusty that I missed something;
> I was in an easy going frame of mind when I read it. I do
> tougher reviews when I am more irritated and untrusting.
>
Is OK, looks like Rusty was missing a couple of mk_cpumask_const()
invokations in a -mm patch. I'm currently testing this:
--- 25/include/linux/cpumask.h~make-for_each_cpu-iterator-more-friendly-fix-fix Sat Jan 10 02:15:29 2004
+++ 25-akpm/include/linux/cpumask.h Sat Jan 10 02:16:02 2004
@@ -14,10 +14,10 @@ extern cpumask_t cpu_possible_map;
#define cpu_online(cpu) cpu_isset(cpu, cpu_online_map)
#define cpu_possible(cpu) cpu_isset(cpu, cpu_possible_map)
-#define for_each_cpu_mask(cpu, mask) \
- for (cpu = first_cpu_const(mask); \
- cpu < NR_CPUS; \
- cpu = next_cpu_const(cpu, mask))
+#define for_each_cpu_mask(cpu, mask) \
+ for (cpu = first_cpu_const(mk_cpumask_const(mask)); \
+ cpu < NR_CPUS; \
+ cpu = next_cpu_const(cpu, mk_cpumask_const(mask)))
#define for_each_cpu(cpu) for_each_cpu_mask(cpu, cpu_possible_map)
#define for_each_online_cpu(cpu) for_each_cpu_mask(cpu, cpu_online_map)
_
next reply other threads:[~2004-01-10 7:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-10 7:46 Andrew Morton [this message]
2004-01-10 20:30 ` [PATCH] Updating our sn code in 2.6] - Patch 028 Paul Jackson
2004-01-12 19:11 ` Jesse Barnes
2004-01-12 20:10 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040109234608.18009a2a.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox