* [PATCH] fix cast in irq_lsapic.c
@ 2004-01-16 20:15 Jesse Barnes
2004-01-17 17:06 ` Christoph Hellwig
2004-01-20 1:47 ` Jesse Barnes
0 siblings, 2 replies; 3+ messages in thread
From: Jesse Barnes @ 2004-01-16 20:15 UTC (permalink / raw)
To: linux-ia64
Now that I've disabled dependency violation checking in my build of
binutils, I can see real warnings much more easily.
This patch just updates the cast in irq_lsapic.c to use the cpumask_t
type for the noop cast assignment to smp_affinity.
Jesse
=== arch/ia64/kernel/irq_lsapic.c 1.3 vs edited ==--- 1.3/arch/ia64/kernel/irq_lsapic.c Fri Jul 19 07:02:26 2002
+++ edited/arch/ia64/kernel/irq_lsapic.c Fri Jan 16 12:11:04 2004
@@ -34,5 +34,5 @@
.disable = lsapic_noop,
.ack = lsapic_noop,
.end = lsapic_noop,
- .set_affinity = (void (*)(unsigned int, unsigned long)) lsapic_noop
+ .set_affinity = (void (*)(unsigned int, cpumask_t)) lsapic_noop
};
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix cast in irq_lsapic.c
2004-01-16 20:15 [PATCH] fix cast in irq_lsapic.c Jesse Barnes
@ 2004-01-17 17:06 ` Christoph Hellwig
2004-01-20 1:47 ` Jesse Barnes
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2004-01-17 17:06 UTC (permalink / raw)
To: linux-ia64
On Fri, Jan 16, 2004 at 12:15:22PM -0800, Jesse Barnes wrote:
> Now that I've disabled dependency violation checking in my build of
> binutils, I can see real warnings much more easily.
>
> This patch just updates the cast in irq_lsapic.c to use the cpumask_t
> type for the noop cast assignment to smp_affinity.
I think Jack already sent a patch for this when we were in freeze and
the same comment applies here: I think the method is optional, so you
can probably just remove it, if not please add a properly prototyped
stub function for it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix cast in irq_lsapic.c
2004-01-16 20:15 [PATCH] fix cast in irq_lsapic.c Jesse Barnes
2004-01-17 17:06 ` Christoph Hellwig
@ 2004-01-20 1:47 ` Jesse Barnes
1 sibling, 0 replies; 3+ messages in thread
From: Jesse Barnes @ 2004-01-20 1:47 UTC (permalink / raw)
To: linux-ia64
On Sat, Jan 17, 2004 at 05:06:47PM +0000, Christoph Hellwig wrote:
> On Fri, Jan 16, 2004 at 12:15:22PM -0800, Jesse Barnes wrote:
> > Now that I've disabled dependency violation checking in my build of
> > binutils, I can see real warnings much more easily.
> >
> > This patch just updates the cast in irq_lsapic.c to use the cpumask_t
> > type for the noop cast assignment to smp_affinity.
>
> I think Jack already sent a patch for this when we were in freeze and
> the same comment applies here: I think the method is optional, so you
> can probably just remove it, if not please add a properly prototyped
> stub function for it.
Oh yeah, forgot about that message. Here's an updated patch.
Thanks,
Jesse
=== arch/ia64/kernel/irq_lsapic.c 1.3 vs edited ==--- 1.3/arch/ia64/kernel/irq_lsapic.c Fri Jul 19 07:02:26 2002
+++ edited/arch/ia64/kernel/irq_lsapic.c Mon Jan 19 17:45:48 2004
@@ -34,5 +34,4 @@
.disable = lsapic_noop,
.ack = lsapic_noop,
.end = lsapic_noop,
- .set_affinity = (void (*)(unsigned int, unsigned long)) lsapic_noop
};
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-01-20 1:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-16 20:15 [PATCH] fix cast in irq_lsapic.c Jesse Barnes
2004-01-17 17:06 ` Christoph Hellwig
2004-01-20 1:47 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox