* Re: [PATCH] Add EXPORT_SYMBOL for physical_node_map
2004-02-03 18:57 [PATCH] Add EXPORT_SYMBOL for physical_node_map Martin Hicks
@ 2004-02-03 19:01 ` Christoph Hellwig
2004-02-03 19:03 ` Jesse Barnes
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Christoph Hellwig @ 2004-02-03 19:01 UTC (permalink / raw)
To: linux-ia64
On Tue, Feb 03, 2004 at 01:57:28PM -0500, Martin Hicks wrote:
> Can you please include this EXPORT_SYMBOL in the next release. A few
> macros that use physical_node_map are used in modules.
which module? There isn't one in the current tree and it would have to
be horribly SN2-specific as it's a SN2 only variable.
And no, my $RANDOM binary module doesn't count.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Add EXPORT_SYMBOL for physical_node_map
2004-02-03 18:57 [PATCH] Add EXPORT_SYMBOL for physical_node_map Martin Hicks
2004-02-03 19:01 ` Christoph Hellwig
@ 2004-02-03 19:03 ` Jesse Barnes
2004-02-03 19:04 ` Martin Hicks
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jesse Barnes @ 2004-02-03 19:03 UTC (permalink / raw)
To: linux-ia64
You should probably include module.h too...
On Tue, Feb 03, 2004 at 01:57:28PM -0500, Martin Hicks wrote:
>
> Hi David,
>
> Can you please include this EXPORT_SYMBOL in the next release. A few
> macros that use physical_node_map are used in modules.
>
> Thanks
> mh
>
> --
> Martin Hicks Wild Open Source Inc.
> mort@wildopensource.com 613-266-2296
> # This is a BitKeeper generated patch for the following project:
> # Project Name: Linux kernel tree
> # This patch format is intended for GNU patch command version 2.5 or higher.
> # This patch includes the following deltas:
> # ChangeSet 1.1542 -> 1.1543
> # arch/ia64/sn/kernel/setup.c 1.28 -> 1.29
> #
> # The following is the BitKeeper ChangeSet Log
> # --------------------------------------------
> # 04/02/03 mort@green.i.bork.org 1.1543
> # EXPORT_SYMBOL for physical_node_map. This is required
> # for some SN2 modules.
> # --------------------------------------------
> #
> diff -Nru a/arch/ia64/sn/kernel/setup.c b/arch/ia64/sn/kernel/setup.c
> --- a/arch/ia64/sn/kernel/setup.c Tue Feb 3 12:52:53 2004
> +++ b/arch/ia64/sn/kernel/setup.c Tue Feb 3 12:52:53 2004
> @@ -70,6 +70,8 @@
>
> short physical_node_map[MAX_PHYSNODE_ID];
>
> +EXPORT_SYMBOL(physical_node_map);
> +
> int numionodes;
>
> /*
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Add EXPORT_SYMBOL for physical_node_map
2004-02-03 18:57 [PATCH] Add EXPORT_SYMBOL for physical_node_map Martin Hicks
2004-02-03 19:01 ` Christoph Hellwig
2004-02-03 19:03 ` Jesse Barnes
@ 2004-02-03 19:04 ` Martin Hicks
2004-02-03 19:06 ` Christoph Hellwig
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Martin Hicks @ 2004-02-03 19:04 UTC (permalink / raw)
To: linux-ia64
On Tue, Feb 03, 2004 at 07:01:51PM +0000, Christoph Hellwig wrote:
> On Tue, Feb 03, 2004 at 01:57:28PM -0500, Martin Hicks wrote:
> > Can you please include this EXPORT_SYMBOL in the next release. A few
> > macros that use physical_node_map are used in modules.
>
> which module? There isn't one in the current tree and it would have to
> be horribly SN2-specific as it's a SN2 only variable.
>
> And no, my $RANDOM binary module doesn't count.
Yes, that's what it is. Some-random-binary-module.
It does pollute GENERIC a bit, but I didn't think that would matter too
much.
--
Martin Hicks Wild Open Source Inc.
mort@wildopensource.com 613-266-2296
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Add EXPORT_SYMBOL for physical_node_map
2004-02-03 18:57 [PATCH] Add EXPORT_SYMBOL for physical_node_map Martin Hicks
` (2 preceding siblings ...)
2004-02-03 19:04 ` Martin Hicks
@ 2004-02-03 19:06 ` Christoph Hellwig
2004-02-10 21:51 ` David Mosberger
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Christoph Hellwig @ 2004-02-03 19:06 UTC (permalink / raw)
To: linux-ia64
On Tue, Feb 03, 2004 at 02:04:53PM -0500, Martin Hicks wrote:
> > which module? There isn't one in the current tree and it would have to
> > be horribly SN2-specific as it's a SN2 only variable.
> >
> > And no, my $RANDOM binary module doesn't count.
>
> Yes, that's what it is. Some-random-binary-module.
>
> It does pollute GENERIC a bit, but I didn't think that would matter too
> much.
Well, then you're on your own. Export it in the SGI tree if your lawyers
feel comfortable with it.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Add EXPORT_SYMBOL for physical_node_map
2004-02-03 18:57 [PATCH] Add EXPORT_SYMBOL for physical_node_map Martin Hicks
` (3 preceding siblings ...)
2004-02-03 19:06 ` Christoph Hellwig
@ 2004-02-10 21:51 ` David Mosberger
2004-02-10 21:58 ` Jesse Barnes
2004-02-11 21:23 ` Martin Hicks
6 siblings, 0 replies; 8+ messages in thread
From: David Mosberger @ 2004-02-10 21:51 UTC (permalink / raw)
To: linux-ia64
>>>>> On Tue, 3 Feb 2004 13:57:28 -0500, Martin Hicks <mort@wildopensource.com> said:
Martin> Can you please include this EXPORT_SYMBOL in the next release. A few
Martin> macros that use physical_node_map are used in modules.
I share Christoph's concern but since this code is SGI's and Jesse is
apparently OK with it, I'd have applied it---if only the patch
actually applied. I think there is some whitespace breakage in your
patch.
--david
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Add EXPORT_SYMBOL for physical_node_map
2004-02-03 18:57 [PATCH] Add EXPORT_SYMBOL for physical_node_map Martin Hicks
` (4 preceding siblings ...)
2004-02-10 21:51 ` David Mosberger
@ 2004-02-10 21:58 ` Jesse Barnes
2004-02-11 21:23 ` Martin Hicks
6 siblings, 0 replies; 8+ messages in thread
From: Jesse Barnes @ 2004-02-10 21:58 UTC (permalink / raw)
To: linux-ia64
On Tue, Feb 10, 2004 at 01:51:43PM -0800, David Mosberger wrote:
> >>>>> On Tue, 3 Feb 2004 13:57:28 -0500, Martin Hicks <mort@wildopensource.com> said:
>
> Martin> Can you please include this EXPORT_SYMBOL in the next release. A few
> Martin> macros that use physical_node_map are used in modules.
>
> I share Christoph's concern but since this code is SGI's and Jesse is
> apparently OK with it, I'd have applied it---if only the patch
> actually applied. I think there is some whitespace breakage in your
> patch.
Yep, I'm ok with it. The modules that depend on it should be released
under the GPL soon. Robin is working on getting them into shape for
inclusion into the mainline tree.
Thanks,
Jesse
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Add EXPORT_SYMBOL for physical_node_map
2004-02-03 18:57 [PATCH] Add EXPORT_SYMBOL for physical_node_map Martin Hicks
` (5 preceding siblings ...)
2004-02-10 21:58 ` Jesse Barnes
@ 2004-02-11 21:23 ` Martin Hicks
6 siblings, 0 replies; 8+ messages in thread
From: Martin Hicks @ 2004-02-11 21:23 UTC (permalink / raw)
To: linux-ia64
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Tue, Feb 10, 2004 at 01:51:43PM -0800, David Mosberger wrote:
> >>>>> On Tue, 3 Feb 2004 13:57:28 -0500, Martin Hicks <mort@wildopensource.com> said:
>
> Martin> Can you please include this EXPORT_SYMBOL in the next release. A few
> Martin> macros that use physical_node_map are used in modules.
>
> I share Christoph's concern but since this code is SGI's and Jesse is
> apparently OK with it, I'd have applied it---if only the patch
> actually applied. I think there is some whitespace breakage in your
> patch.
Here's another attempt then. Against Linus' latest bk tree.
mh
--
Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE
[-- Attachment #2: physical_node_map-2.patch --]
[-- Type: text/plain, Size: 899 bytes --]
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1610 -> 1.1611
# arch/ia64/sn/kernel/setup.c 1.31 -> 1.32
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/02/11 mort@green.i.bork.org 1.1611
# Export physical_node_map
# --------------------------------------------
#
diff -Nru a/arch/ia64/sn/kernel/setup.c b/arch/ia64/sn/kernel/setup.c
--- a/arch/ia64/sn/kernel/setup.c Wed Feb 11 16:21:36 2004
+++ b/arch/ia64/sn/kernel/setup.c Wed Feb 11 16:21:36 2004
@@ -71,6 +71,8 @@
short physical_node_map[MAX_PHYSNODE_ID];
+EXPORT_SYMBOL(physical_node_map);
+
int numionodes;
/*
* This is the address of the RRegs in the HSpace of the global
^ permalink raw reply [flat|nested] 8+ messages in thread