Re: [PATCH] turn off irqdebug by default on Altix

[Martin Hicks <mort@sgi.com>]

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]



On Tue, Feb 10, 2004 at 02:43:14PM -0800, David Mosberger wrote:
> >>>>> On Thu, 5 Feb 2004 13:37:28 -0500, Martin Hicks <mort@sgi.com> said:
> 
>   Martin> How about this patch?  I just tested it on a 512p machine
>   Martin> and it booted.
> 
> I suspect a better fix would be to change do_IRQ() such that it
> doesn't call note_interrupt() for IRQ_PER_CPU interrupts.  For per-CPU
> interrupts, the note_interrupt() code is racy and rather bogus anyhow.

Okay....Here it is.

I didn't test it on a big machine yet, but it certainly seems like it
takes care of the problem.

mh

-- 
Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE

[-- Attachment #2: no-note-interrupt.patch --]
[-- Type: text/plain, Size: 977 bytes --]

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1609  -> 1.1610 
#	arch/ia64/kernel/irq.c	1.34    -> 1.35   
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/02/11	mort@green.i.bork.org	1.1610
# Don't call note_interrupt() for per-cpu interrupts.
# --------------------------------------------
#
diff -Nru a/arch/ia64/kernel/irq.c b/arch/ia64/kernel/irq.c
--- a/arch/ia64/kernel/irq.c	Wed Feb 11 16:17:22 2004
+++ b/arch/ia64/kernel/irq.c	Wed Feb 11 16:17:22 2004
@@ -465,8 +465,6 @@
 		desc->handler->ack(irq);
 		action_ret = handle_IRQ_event(irq, regs, desc->action);
 		desc->handler->end(irq);
-		if (!noirqdebug)
-			note_interrupt(irq, desc, action_ret);
 	} else {
 		spin_lock(&desc->lock);
 		desc->handler->ack(irq);