From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] 2.4.25 sync unwind code with 2.6.3
Date: Wed, 03 Mar 2004 23:53:36 +0000 [thread overview]
Message-ID: <200403031653.36428.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <3792.1077504388@kao2.melbourne.sgi.com>
On Sunday 22 February 2004 7:46 pm, Keith Owens wrote:
> The unwind code in 2.4.25 has drifted away from the 2.6.3 version,
> including some missing bug fixes.
> + /* Kludge: 2.4 has down_write_trylock on semaphores but not write_trylock on
> + * spinlocks, even though they are both in 2.6 and are identical. Pretend
> + * that script lock is a rw_semaphore so we can use the only 2.4 code that
> + * avoids a deadlock. KAO.
> + */
> + if (!down_write_trylock((struct rw_semaphore *)(&script->lock)))
> + return NULL;
Should we consider putting write_trylock() in 2.4? It looks like
i386, x86_64, and ppc64 already have it.
We also have this diff wrt. 2.6:
@@ -1426,7 +1416,7 @@
case UNW_WHERE_FR:
if (rval <= 5)
- val = unw.preg_index[UNW_REG_F2 + (rval - 1)];
+ val = unw.preg_index[UNW_REG_F2 + (rval - 2)];
else if (rval >= 16 && rval <= 31)
val = unw.preg_index[UNW_REG_F16 + (rval - 16)];
else {
You didn't change this, but I'd feel better if I understood why
this is different.
I applied your patch, and also twidded the UNW_DEBUG bits to
make 2.4 more like 2.6. Thanks for keeping them in sync!
Bjorn
next prev parent reply other threads:[~2004-03-03 23:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-23 2:46 [patch] 2.4.25 sync unwind code with 2.6.3 Keith Owens
2004-02-23 20:12 ` David Mosberger
2004-03-03 23:53 ` Bjorn Helgaas [this message]
2004-03-04 0:09 ` David Mosberger
2004-03-04 0:22 ` Keith Owens
2004-03-04 0:40 ` Bjorn Helgaas
2004-03-04 0:43 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403031653.36428.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox