From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] 2.4.25 sync unwind code with 2.6.3
Date: Thu, 04 Mar 2004 00:40:16 +0000 [thread overview]
Message-ID: <200403031740.16423.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <3792.1077504388@kao2.melbourne.sgi.com>
On Wednesday 03 March 2004 5:09 pm, David Mosberger wrote:
> >>>>> On Wed, 3 Mar 2004 16:53:36 -0700, Bjorn Helgaas <bjorn.helgaas@hp.com> said:
>
> > - val = unw.preg_index[UNW_REG_F2 + (rval - 1)];
> > + val = unw.preg_index[UNW_REG_F2 + (rval - 2)];
>
> > You didn't change this, but I'd feel better if I understood
> > why this is different.
>
> It was a typo. The code is needed to handle f2-f5, hence the "- 2".
Ah, and I bet that's the one you mentioned on 2/23 with this link:
http://lia64.bkbits.net:8080/to-linus-2.5/cset@1.1659
(which no longer points the right place -- rats, bitten again by
the fact that BK cset numbers change after the fact :-()
Thanks for straightening me out. I'll apply the following patch to
2.4 so it will be the same as 2.6 in this regard:
=== arch/ia64/kernel/unwind.c 1.30 vs edited ==--- 1.30/arch/ia64/kernel/unwind.c Wed Mar 3 16:51:27 2004
+++ edited/arch/ia64/kernel/unwind.c Wed Mar 3 17:33:27 2004
@@ -1420,7 +1420,7 @@
case UNW_WHERE_FR:
if (rval <= 5)
- val = unw.preg_index[UNW_REG_F2 + (rval - 1)];
+ val = unw.preg_index[UNW_REG_F2 + (rval - 2)];
else if (rval >= 16 && rval <= 31)
val = unw.preg_index[UNW_REG_F16 + (rval - 16)];
else {
next prev parent reply other threads:[~2004-03-04 0:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-23 2:46 [patch] 2.4.25 sync unwind code with 2.6.3 Keith Owens
2004-02-23 20:12 ` David Mosberger
2004-03-03 23:53 ` Bjorn Helgaas
2004-03-04 0:09 ` David Mosberger
2004-03-04 0:22 ` Keith Owens
2004-03-04 0:40 ` Bjorn Helgaas [this message]
2004-03-04 0:43 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403031740.16423.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox