Compilation problem in arch/ia64/sn/kernel/setup.c

Compilation problem in arch/ia64/sn/kernel/setup.c

[Sourav Sen]

Hello,

In arch/ia64/sn/kernel/setup.c in 2.6.4 + IA64 patch,
the array, platform_intr_list[] is declared
as:

#ifdef CONFIG_IA64_MCA
extern int platform_intr_list[];
#endif

but is used without that (CONFIG_IA64_MCA) guard.
So, I have done the following to get around the
compilation problem. Somebody knowledgeable on
this will be able to validate if this is the
right way.

regards
Sourav

--- arch/ia64/sn/kernel/setup.c.orig    Mon Mar 15 05:58:30 2004
+++ arch/ia64/sn/kernel/setup.c Mon Mar 15 05:59:14 2004
@@ -311,7 +311,9 @@
        else
                sn_rtc_cycles_per_second = ticks_per_sec;
 
+#ifdef CONFIG_IA64_MCA
        platform_intr_list[ACPI_INTERRUPT_CPEI] = IA64_CPE_VECTOR;
+#endif
 
 
        if ( IS_RUNNING_ON_SIMULATOR() )

Re: Compilation problem in arch/ia64/sn/kernel/setup.c

[Jesse Barnes]

The patch looks fine, but I wonder if we really need CONFIG_IA64_MCA
anymore, does anyone really want to run without it?

Jesse

On Mon, Mar 15, 2004 at 11:52:03AM +0530, Sourav Sen wrote:
> Hello,
> 
> In arch/ia64/sn/kernel/setup.c in 2.6.4 + IA64 patch,
> the array, platform_intr_list[] is declared
> as:
> 
> #ifdef CONFIG_IA64_MCA
> extern int platform_intr_list[];
> #endif
> 
> but is used without that (CONFIG_IA64_MCA) guard.
> So, I have done the following to get around the
> compilation problem. Somebody knowledgeable on
> this will be able to validate if this is the
> right way.
> 
> regards
> Sourav
> 
> --- arch/ia64/sn/kernel/setup.c.orig    Mon Mar 15 05:58:30 2004
> +++ arch/ia64/sn/kernel/setup.c Mon Mar 15 05:59:14 2004
> @@ -311,7 +311,9 @@
>         else
>                 sn_rtc_cycles_per_second = ticks_per_sec;
>  
> +#ifdef CONFIG_IA64_MCA
>         platform_intr_list[ACPI_INTERRUPT_CPEI] = IA64_CPE_VECTOR;
> +#endif
>  
>  
>         if ( IS_RUNNING_ON_SIMULATOR() )
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Compilation problem in arch/ia64/sn/kernel/setup.c

[David Mosberger]

>>>>> On Mon, 15 Mar 2004 08:59:39 -0800, jbarnes@sgi.com (Jesse Barnes) said:

  Jesse> The patch looks fine, but I wonder if we really need
  Jesse> CONFIG_IA64_MCA anymore, does anyone really want to run
  Jesse> without it?

Good point.  MCA used to be rather big because of all the
decoding-crap, but now that's cleaned up, so perhaps there is no
reason to keep CONFIG_IA64_MCA anymore (even the usual Ski simulator
config has CONFIG_IA64_MCA turned on, even though the supporting
firmware-emulator doesn't really do anything about MCAs at the
moment).

	--david