* [PATCH] fix sn_serial warning
@ 2004-03-29 18:58 Jesse Barnes
0 siblings, 0 replies; only message in thread
From: Jesse Barnes @ 2004-03-29 18:58 UTC (permalink / raw)
To: linux-ia64
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
In my fixes to quiet the sn_serial driver, I made sn_debug_printf only get
used when the DEBUG define was turned on in the driver but forgot to #ifdef
out the function definition, causing an 'defined but not used' warning. This
patch fixes that.
Jesse
[-- Attachment #2: sn-serial-warning-fixes.patch --]
[-- Type: text/plain, Size: 802 bytes --]
===== drivers/char/sn_serial.c 1.10 vs edited =====
--- 1.10/drivers/char/sn_serial.c Mon Mar 22 02:29:18 2004
+++ edited/drivers/char/sn_serial.c Mon Mar 29 10:48:14 2004
@@ -82,10 +82,10 @@
static unsigned long sn_interrupt_timeout;
extern u64 master_node_bedrock_address;
-static int sn_debug_printf(const char *fmt, ...);
#undef DEBUG
#ifdef DEBUG
+static int sn_debug_printf(const char *fmt, ...);
#define DPRINTF(x...) sn_debug_printf(x)
#else
#define DPRINTF(x...) do { } while (0)
@@ -247,6 +247,7 @@
sn_func->sal_puts(s, count);
}
+#ifdef DEBUG
/* this is as "close to the metal" as we can get, used when the driver
* itself may be broken */
static int
@@ -262,6 +263,7 @@
va_end(args);
return printed_len;
}
+#endif /* DEBUG */
/*
* Interrupt handling routines.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-03-29 18:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-29 18:58 [PATCH] fix sn_serial warning Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox