Linux IA64 platform development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] 2.6.6 SN2 specific prom flag in mca.c
Date: Mon, 10 May 2004 15:15:37 +0000	[thread overview]
Message-ID: <200405100915.37605.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <11478.1084168536@kao2.melbourne.sgi.com>

On Sunday 09 May 2004 11:55 pm, Keith Owens wrote:
> SN2 prom needs an extra flag on the MCA setup call.

If the flag is needed always and only on SN2, why doesn't the
prom just set it implicitly?

> Index: 2.6.6/arch/ia64/kernel/mca.c
> =================================> --- 2.6.6.orig/arch/ia64/kernel/mca.c	2004-04-05 12:43:31.000000000 -0500
> +++ 2.6.6/arch/ia64/kernel/mca.c	2004-04-05 12:52:48.000000000 -0500
> @@ -1207,6 +1207,9 @@
>  	s64 rc;
>  	struct ia64_sal_retval isrv;
>  	u64 timeout = IA64_MCA_RENDEZ_TIMEOUT;	/* platform specific */
> +	u64 mca_flags = SAL_MC_PARAM_RZ_ALWAYS;	/* platform specific */
> +	if (ia64_platform_is("sn2"))
> +		mca_flags |= 0x8;		/* SGI prom specific */
>  
>  	IA64_MCA_DEBUG("%s: begin\n", __FUNCTION__);
>  
> @@ -1224,7 +1227,7 @@
>  					      SAL_MC_PARAM_MECHANISM_INT,
>  					      IA64_MCA_RENDEZ_VECTOR,
>  					      timeout,
> -					      SAL_MC_PARAM_RZ_ALWAYS);
> +					      mca_flags);
>  		rc = isrv.status;
>  		if (rc = 0)
>  			break;
> 
> -

  reply	other threads:[~2004-05-10 15:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-10  5:55 [patch] 2.6.6 SN2 specific prom flag in mca.c Keith Owens
2004-05-10 15:15 ` Bjorn Helgaas [this message]
2004-05-10 15:47 ` Luck, Tony
2004-05-10 17:53 ` David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405100915.37605.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox