From: edwardsg@sgi.com (Greg Edwards)
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] set EXEC_PAGESIZE to PAGE_SIZE
Date: Tue, 11 May 2004 16:39:31 +0000 [thread overview]
Message-ID: <20040511163931.GB24203@sgi.com> (raw)
In-Reply-To: <20040511145923.GC23495@sgi.com>
On Tue, May 11, 2004 at 06:24:22PM +0200, Andreas Schwab wrote:
| edwardsg@sgi.com (Greg Edwards) writes:
|
| > The number of pages allocated for the gid_t * blocks[] array in the
| > group_info struct is calculated from EXEC_PAGESIZE. This is used when
| > the number of groups goes above 32. On ia64, this is currently
| > hard-coded at 65536, which results in only a 1/4 of the required pages
| > being allocated on a 16k page size kernel. A setgroups() call with a
| > gidsetsize of 65536 will end up tromping on memory. Patch below sets
| > EXEC_PAGESIZE to PAGE_SIZE.
|
| IMHO the real bug is that EXEC_PAGESIZE is used in the first place.
| EXEC_PAGESIZE is supposed to be the biggest page size supported by any
| executable, thus is should always be the max of all possible page sizes.
| It has no relation to the actual page size of the running kernel.
Thanks for pointing that out, Andreas. I'll take a look and see if any
arches have a problem with calculating NGROUPS_PER_BLOCK from
PAGE_SIZE instead of EXEC_PAGESIZE, then I'll send something to lkml.
Greg
prev parent reply other threads:[~2004-05-11 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-11 14:59 [PATCH] set EXEC_PAGESIZE to PAGE_SIZE Greg Edwards
2004-05-11 16:10 ` David Mosberger
2004-05-11 16:24 ` Andreas Schwab
2004-05-11 16:39 ` Greg Edwards [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040511163931.GB24203@sgi.com \
--to=edwardsg@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox