From: Andreas Schwab <schwab@suse.de>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] set EXEC_PAGESIZE to PAGE_SIZE
Date: Tue, 11 May 2004 16:24:22 +0000 [thread overview]
Message-ID: <jen04fdj9l.fsf@sykes.suse.de> (raw)
In-Reply-To: <20040511145923.GC23495@sgi.com>
edwardsg@sgi.com (Greg Edwards) writes:
> The number of pages allocated for the gid_t * blocks[] array in the
> group_info struct is calculated from EXEC_PAGESIZE. This is used when
> the number of groups goes above 32. On ia64, this is currently
> hard-coded at 65536, which results in only a 1/4 of the required pages
> being allocated on a 16k page size kernel. A setgroups() call with a
> gidsetsize of 65536 will end up tromping on memory. Patch below sets
> EXEC_PAGESIZE to PAGE_SIZE.
IMHO the real bug is that EXEC_PAGESIZE is used in the first place.
EXEC_PAGESIZE is supposed to be the biggest page size supported by any
executable, thus is should always be the max of all possible page sizes.
It has no relation to the actual page size of the running kernel.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2004-05-11 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-11 14:59 [PATCH] set EXEC_PAGESIZE to PAGE_SIZE Greg Edwards
2004-05-11 16:10 ` David Mosberger
2004-05-11 16:24 ` Andreas Schwab [this message]
2004-05-11 16:39 ` Greg Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jen04fdj9l.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox