From: Christoph Hellwig <hch@infradead.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH 3/4] SGI Altix cross partition functionality
Date: Tue, 22 Jun 2004 18:26:15 +0000 [thread overview]
Message-ID: <20040622182615.GA7251@infradead.org> (raw)
In-Reply-To: <20040617183638.GA3712@sgi.com>
On Tue, Jun 22, 2004 at 01:17:07PM -0500, Dean Nelson wrote:
> On Thu, Jun 17, 2004 at 08:22:29PM +0100, Christoph Hellwig wrote:
> >
> > +} xpc_vars_t;
> >
> > please kill all the typedef gunk.
>
> I'm in the process of ditching all of my typedef's. But before I axed the
> following two I thought I'd ask if an exception should be made in their
> case? Or are all typedef's deemed offlimits without exception?
>
> typedef void (*xpc_channel_func_t)(enum xpc_retval, partid_t, int,
> void *, void *);
>
> typedef void (*xpc_notify_func_t)(enum xpc_retval, partid_t, int,
> void *);
>
> (Note: I had nothing to do with the partid_t typedef.)
Thos are okay. In the kernel we often don't use _t postfixes for those
either, but it doesn't really matter.
next prev parent reply other threads:[~2004-06-22 18:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-17 18:36 [PATCH 3/4] SGI Altix cross partition functionality Dean Nelson
2004-06-17 19:22 ` Christoph Hellwig
2004-06-17 19:42 ` Dean Nelson
2004-06-22 18:17 ` Dean Nelson
2004-06-22 18:26 ` Christoph Hellwig [this message]
2004-07-07 19:40 ` Dean Nelson
2004-07-11 10:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040622182615.GA7251@infradead.org \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox