From: Jesse Barnes <jbarnes@engr.sgi.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] kill warning in bte.c
Date: Tue, 10 Aug 2004 00:35:47 +0000 [thread overview]
Message-ID: <200408091735.47593.jbarnes@engr.sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
Robin or Dean, feel free to veto this one if it's not valid. A recent patch
caused a warning about not using expressions as lvalues to crop up in bte.c
(or maybe it's just that I'm using gcc-3.4.1 now). This patch fixes it by
creating a temporary to store the register whose address we want to get and
stuff into the per-bte info structure.
Signed-off-by: Jesse Barnes <jbarnes@sgi.com>
Thanks,
Jesse
[-- Attachment #2: bte-warning-fix.patch --]
[-- Type: text/plain, Size: 717 bytes --]
===== arch/ia64/sn/kernel/bte.c 1.7 vs edited =====
--- 1.7/arch/ia64/sn/kernel/bte.c 2004-07-30 14:05:59 -07:00
+++ edited/arch/ia64/sn/kernel/bte.c 2004-08-09 14:41:24 -07:00
@@ -421,9 +421,10 @@
mynodepda->bte_recovery_timer.data = (unsigned long) mynodepda;
for (i = 0; i < BTES_PER_NODE; i++) {
- (u64) mynodepda->bte_if[i].bte_base_addr =
- REMOTE_HUB_ADDR(cnodeid_to_nasid(cnode),
- (i == 0 ? IIO_IBLS0 : IIO_IBLS1));
+ /* Which link status register should we use? */
+ unsigned long link_status = (i == 0 ? IIO_IBLS0 : IIO_IBLS1);
+ mynodepda->bte_if[i].bte_base_addr = (u64 *)
+ REMOTE_HUB_ADDR(cnodeid_to_nasid(cnode), link_status);
/*
* Initialize the notification and spinlock
reply other threads:[~2004-08-10 0:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408091735.47593.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox