* [PATCH] kill warning in bte.c
@ 2004-08-10 0:35 Jesse Barnes
0 siblings, 0 replies; only message in thread
From: Jesse Barnes @ 2004-08-10 0:35 UTC (permalink / raw)
To: linux-ia64
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
Robin or Dean, feel free to veto this one if it's not valid. A recent patch
caused a warning about not using expressions as lvalues to crop up in bte.c
(or maybe it's just that I'm using gcc-3.4.1 now). This patch fixes it by
creating a temporary to store the register whose address we want to get and
stuff into the per-bte info structure.
Signed-off-by: Jesse Barnes <jbarnes@sgi.com>
Thanks,
Jesse
[-- Attachment #2: bte-warning-fix.patch --]
[-- Type: text/plain, Size: 717 bytes --]
===== arch/ia64/sn/kernel/bte.c 1.7 vs edited =====
--- 1.7/arch/ia64/sn/kernel/bte.c 2004-07-30 14:05:59 -07:00
+++ edited/arch/ia64/sn/kernel/bte.c 2004-08-09 14:41:24 -07:00
@@ -421,9 +421,10 @@
mynodepda->bte_recovery_timer.data = (unsigned long) mynodepda;
for (i = 0; i < BTES_PER_NODE; i++) {
- (u64) mynodepda->bte_if[i].bte_base_addr =
- REMOTE_HUB_ADDR(cnodeid_to_nasid(cnode),
- (i == 0 ? IIO_IBLS0 : IIO_IBLS1));
+ /* Which link status register should we use? */
+ unsigned long link_status = (i == 0 ? IIO_IBLS0 : IIO_IBLS1);
+ mynodepda->bte_if[i].bte_base_addr = (u64 *)
+ REMOTE_HUB_ADDR(cnodeid_to_nasid(cnode), link_status);
/*
* Initialize the notification and spinlock
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-08-10 0:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-10 0:35 [PATCH] kill warning in bte.c Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox