From: Christoph Hellwig <hch@infradead.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] add coherence id for SGI Altix systems
Date: Fri, 13 Aug 2004 18:15:24 +0000 [thread overview]
Message-ID: <20040813191524.A13892@infradead.org> (raw)
In-Reply-To: <200408131756.i7DHuWNi036140@shaft.americas.sgi.com>
On Fri, Aug 13, 2004 at 12:56:32PM -0500, Dean Roe wrote:
> +static int coherence_id_read_proc(char *page, char **start, off_t off,
> + int count, int *eof, void *data) {
The { needs to go on a new line
> + return sprintf(page, "%d\n", cpuid_to_coherence_id(smp_processor_id()));
> +}
please use the seq_file api.
> +void
> +register_sn_coherence_id(void) {
{ pleasement again, and this should be static.
> + struct proc_dir_entry *entry;
> +
> + if (!sgi_proc_dir) {
> + sgi_proc_dir = proc_mkdir("sgi_sn", 0);
> + }
don't SN2 systems have this directory already?
> + entry->nlink = 1;
> + entry->data = 0;
no need to set this two.
> + entry->write_proc = NULL;
dito.
also while you're at it convert the whole file to seq_file and proper
coding style.
next prev parent reply other threads:[~2004-08-13 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-13 17:56 [PATCH] add coherence id for SGI Altix systems Dean Roe
2004-08-13 18:15 ` Christoph Hellwig [this message]
2004-08-13 18:41 ` Russ Anderson
2004-08-13 18:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040813191524.A13892@infradead.org \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox