From: Christoph Hellwig <hch@infradead.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] add coherence id for SGI Altix systems
Date: Fri, 13 Aug 2004 18:45:34 +0000 [thread overview]
Message-ID: <20040813194534.A14135@infradead.org> (raw)
In-Reply-To: <200408131756.i7DHuWNi036140@shaft.americas.sgi.com>
On Fri, Aug 13, 2004 at 01:41:13PM -0500, Russ Anderson wrote:
> Christoph Hellwig wrote:
> >
> > also while you're at it convert the whole file to seq_file and proper
> > coding style.
>
> Shouldn't coding style changes be a separate patch? Otherwise
> it's hard to tell the real changes from the code style changes.
"while you're at it" wasn't meant as in the same patch, but as a reminder
that additional patches to clean up that area would be very welcome ;-)
prev parent reply other threads:[~2004-08-13 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-13 17:56 [PATCH] add coherence id for SGI Altix systems Dean Roe
2004-08-13 18:15 ` Christoph Hellwig
2004-08-13 18:41 ` Russ Anderson
2004-08-13 18:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040813194534.A14135@infradead.org \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox