From: Matthew Wilcox <matthew@wil.cx>
To: Pat Gefre <pfg@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6.10 Altix : ioc4 serial driver support
Date: Thu, 16 Dec 2004 22:43:05 +0000 [thread overview]
Message-ID: <20041216224304.GE7113@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <200412162224.iBGMOQ52284713@fsgi900.americas.sgi.com>
On Thu, Dec 16, 2004 at 04:24:26PM -0600, Pat Gefre wrote:
> I have a serial driver for Altix I'd like to submit.
Why put it in arch/ia64/sn/io/sn2/driver/ioc4_serial.c ?!
drivers/serial/ioc4.c would be the right place for it. You put the
Kconfig there -- that should be a clue.
It seems like you're directly dereferencing pointers to io memory instead
of calling readb and friends. I know, this driver doesn't need to be
portable, but it helps any casual reader of this driver figure out what's
going on. And you can get rid of the 'volatile' that way ;-)
Linux Device Drivers, Second edition says you shouldn't use SA_INTERRUPT
without good reason (http://www.xml.com/ldd/chapter/book/ch09.html#t3)
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2004-12-16 22:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-16 22:24 [PATCH] 2.6.10 Altix : ioc4 serial driver support Pat Gefre
2004-12-16 22:43 ` Matthew Wilcox [this message]
2004-12-16 23:15 ` Christoph Hellwig
2004-12-17 16:24 ` Matthew Wilcox
2004-12-17 22:14 ` Patrick Gefre
2004-12-18 14:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041216224304.GE7113@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox