From: Jesse Barnes <jbarnes@engr.sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] - Update SN2 code for running on simulator
Date: Tue, 04 Jan 2005 16:24:33 +0000 [thread overview]
Message-ID: <200501040824.33474.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <20050104142411.GA22312@sgi.com>
On Tuesday, January 4, 2005 6:24 am, Jack Steiner wrote:
> + addr = (is_shub2() ? 0xc00000028c000000 : 0xc0000087cc000000) | ((port
> >> 2) << 12); + if ((port >= 0x1f0 && port <= 0x1f7) || port = 0x3f6 ||
> port = 0x3f7) + addr |= port;
> return (void *)addr;
> }
> }
Can we keep the UL specifiers in there? It helps silence sparse and is a
little more correct.
Thanks,
Jesse
next prev parent reply other threads:[~2005-01-04 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-04 14:24 [PATCH] - Update SN2 code for running on simulator Jack Steiner
2005-01-04 16:24 ` Jesse Barnes [this message]
2005-01-04 17:09 ` [PATCH] - Update SN2 code for running on simulator (2nd try) Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501040824.33474.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox