From: Jesse Barnes <jbarnes@engr.sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: sn/kernel/irq.o link failure in 2.6.10
Date: Thu, 06 Jan 2005 21:29:34 +0000 [thread overview]
Message-ID: <200501061329.34594.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <20050106202618.GC6009@jale>
On Thursday, January 6, 2005 12:26 pm, dann frazier wrote:
> arch/ia64/sn/built-in.o(.text+0x1ee2): In function `sn_set_affinity_irq':
> : undefined reference to `set_irq_affinity_info'
>
> We probably need to wrap the set_irq_affinity_info in an #ifdef CONFIG_SMP
> - but should other code be ifdef'd out as well?
>
> --- kernel-source-2.6.10/arch/ia64/sn/kernel/irq.c.orig 2005-01-06
> 12:40:30.170327564 -0700 +++
> kernel-source-2.6.10/arch/ia64/sn/kernel/irq.c 2005-01-06
> 13:25:36.521856911 -0700 @@ -183,7 +183,9 @@
>
> sn_irq_info = sn_irq_info->irq_next;
>
> +#ifdef CONFIG_SMP
> set_irq_affinity_info((irq & 0xff), cpuphys, 0);
> +#endif
> } else {
> break; /* snp_affinity failed the intr_alloc */
> }
I'd rather see a no-op version added under #else /* !CONFIG_SMP */ in
arch/ia64/kernel/irq.c...
Jesse
prev parent reply other threads:[~2005-01-06 21:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 20:26 sn/kernel/irq.o link failure in 2.6.10 dann frazier
2005-01-06 21:29 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501061329.34594.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox