* sn/kernel/irq.o link failure in 2.6.10
@ 2005-01-06 20:26 dann frazier
2005-01-06 21:29 ` Jesse Barnes
0 siblings, 1 reply; 2+ messages in thread
From: dann frazier @ 2005-01-06 20:26 UTC (permalink / raw)
To: linux-ia64
arch/ia64/sn/built-in.o(.text+0x1ee2): In function `sn_set_affinity_irq':
: undefined reference to `set_irq_affinity_info'
We probably need to wrap the set_irq_affinity_info in an #ifdef CONFIG_SMP -
but should other code be ifdef'd out as well?
--- kernel-source-2.6.10/arch/ia64/sn/kernel/irq.c.orig 2005-01-06 12:40:30.170327564 -0700
+++ kernel-source-2.6.10/arch/ia64/sn/kernel/irq.c 2005-01-06 13:25:36.521856911 -0700
@@ -183,7 +183,9 @@
sn_irq_info = sn_irq_info->irq_next;
+#ifdef CONFIG_SMP
set_irq_affinity_info((irq & 0xff), cpuphys, 0);
+#endif
} else {
break; /* snp_affinity failed the intr_alloc */
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sn/kernel/irq.o link failure in 2.6.10
2005-01-06 20:26 sn/kernel/irq.o link failure in 2.6.10 dann frazier
@ 2005-01-06 21:29 ` Jesse Barnes
0 siblings, 0 replies; 2+ messages in thread
From: Jesse Barnes @ 2005-01-06 21:29 UTC (permalink / raw)
To: linux-ia64
On Thursday, January 6, 2005 12:26 pm, dann frazier wrote:
> arch/ia64/sn/built-in.o(.text+0x1ee2): In function `sn_set_affinity_irq':
> : undefined reference to `set_irq_affinity_info'
>
> We probably need to wrap the set_irq_affinity_info in an #ifdef CONFIG_SMP
> - but should other code be ifdef'd out as well?
>
> --- kernel-source-2.6.10/arch/ia64/sn/kernel/irq.c.orig 2005-01-06
> 12:40:30.170327564 -0700 +++
> kernel-source-2.6.10/arch/ia64/sn/kernel/irq.c 2005-01-06
> 13:25:36.521856911 -0700 @@ -183,7 +183,9 @@
>
> sn_irq_info = sn_irq_info->irq_next;
>
> +#ifdef CONFIG_SMP
> set_irq_affinity_info((irq & 0xff), cpuphys, 0);
> +#endif
> } else {
> break; /* snp_affinity failed the intr_alloc */
> }
I'd rather see a no-op version added under #else /* !CONFIG_SMP */ in
arch/ia64/kernel/irq.c...
Jesse
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-06 21:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-06 20:26 sn/kernel/irq.o link failure in 2.6.10 dann frazier
2005-01-06 21:29 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox