* [patch 3/3] sn_hwperf.c - vfree() checking cleanups
@ 2005-01-10 19:46 domen
2005-01-10 20:13 ` Jesse Barnes
2005-01-10 20:46 ` Domen Puncer
0 siblings, 2 replies; 3+ messages in thread
From: domen @ 2005-01-10 19:46 UTC (permalink / raw)
To: linux-ia64
sn_hwperf.c vfree() checking cleanups.
Signed-off by: James Lamanna <jlamanna@gmail.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/arch/ia64/sn/kernel/sn2/sn_hwperf.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff -puN arch/ia64/sn/kernel/sn2/sn_hwperf.c~vfree-arch_ia64_sn_kernel_sn2_sn_hwperf arch/ia64/sn/kernel/sn2/sn_hwperf.c
--- kj/arch/ia64/sn/kernel/sn2/sn_hwperf.c~vfree-arch_ia64_sn_kernel_sn2_sn_hwperf 2005-01-10 18:00:56.000000000 +0100
+++ kj-domen/arch/ia64/sn/kernel/sn2/sn_hwperf.c 2005-01-10 18:00:56.000000000 +0100
@@ -529,8 +529,7 @@ sn_hwperf_ioctl(struct inode *in, struct
}
error:
- if (p)
- vfree(p);
+ vfree(p);
lock_kernel();
return r;
@@ -641,7 +640,6 @@ int sn_topology_release(struct inode *in
{
struct seq_file *seq = file->private_data;
- if (seq->private)
- vfree(seq->private);
+ vfree(seq->private);
return seq_release(inode, file);
}
_
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 3/3] sn_hwperf.c - vfree() checking cleanups
2005-01-10 19:46 [patch 3/3] sn_hwperf.c - vfree() checking cleanups domen
@ 2005-01-10 20:13 ` Jesse Barnes
2005-01-10 20:46 ` Domen Puncer
1 sibling, 0 replies; 3+ messages in thread
From: Jesse Barnes @ 2005-01-10 20:13 UTC (permalink / raw)
To: linux-ia64
On Monday, January 10, 2005 11:46 am, domen@coderock.org wrote:
> sn_hwperf.c vfree() checking cleanups.
>
> Signed-off by: James Lamanna <jlamanna@gmail.com>
>
>
> Signed-off-by: Domen Puncer <domen@coderock.org>
Looks ok to me, though Tony Luck (tony.luck@intel.com) is the ia64 maintainer
now.
Acked-by: Jesse Barnes <jbarnes@sgi.com>
Thanks,
Jesse
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 3/3] sn_hwperf.c - vfree() checking cleanups
2005-01-10 19:46 [patch 3/3] sn_hwperf.c - vfree() checking cleanups domen
2005-01-10 20:13 ` Jesse Barnes
@ 2005-01-10 20:46 ` Domen Puncer
1 sibling, 0 replies; 3+ messages in thread
From: Domen Puncer @ 2005-01-10 20:46 UTC (permalink / raw)
To: linux-ia64
On 10/01/05 12:13 -0800, Jesse Barnes wrote:
> On Monday, January 10, 2005 11:46 am, domen@coderock.org wrote:
> > sn_hwperf.c vfree() checking cleanups.
> >
> > Signed-off by: James Lamanna <jlamanna@gmail.com>
> >
> >
> > Signed-off-by: Domen Puncer <domen@coderock.org>
>
> Looks ok to me, though Tony Luck (tony.luck@intel.com) is the ia64 maintainer
> now.
A MAINTAINERS update would be great.
Domen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-10 20:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-10 19:46 [patch 3/3] sn_hwperf.c - vfree() checking cleanups domen
2005-01-10 20:13 ` Jesse Barnes
2005-01-10 20:46 ` Domen Puncer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox