* Re: LKCD on 2.6 IA64 Linux Kernel
2005-01-25 15:16 LKCD on 2.6 IA64 Linux Kernel Sachithanantham_Saravanan
2005-01-25 17:13 ` Robin Holt
@ 2005-01-25 17:48 ` Jason Uhlenkott
2005-01-25 23:58 ` Gerald Pfeifer
2 siblings, 0 replies; 4+ messages in thread
From: Jason Uhlenkott @ 2005-01-25 17:48 UTC (permalink / raw)
To: Sachithanantham_Saravanan
Cc: linux-ia64, yakker, yakker, yakker, matt, linux-kernel
On Tue, Jan 25, 2005 at 03:16:21PM -0000, Sachithanantham_Saravanan@emc.com wrote:
> Hi all,
>
> I tried using lkcd on a ia64 machine running on 2.6.5-7.111 SuSe Kernel for
> debugging. I configured the swap device as the dump device and I created
> panics,oops to generate dumps. The dump happens in /var/log/dump on a "lkcd
> save" after a reboot. When I use lcrash to trace the task of the process
> that caused the dump, I get some data misalignment errors as listed below.
> And interestingly this happens only for the trace of the process that
> generated the panic/oops. For all other processes in the dump trace is
> giving me the proper output. Looks like the issue is specific to ia64 as I
> did not encounter any such errors on my i386 machine on the same kernel.
> Pointers to any patches or what the problem is will be of help to me.
>
> >> trace
> lcrash(9187): unaligned access to 0x6000000001185ff7, ip=0x400000000004fa90
> lcrash(9187): unaligned access to 0x6000000001185ff6, ip=0x400000000004fa90
> lcrash(9187): unaligned access to 0x6000000001185ff5, ip=0x400000000004fa90
> lcrash(9187): unaligned access to 0x6000000001185ff4, ip=0x400000000004fa90
> Can't find trace for running task!
> ================================
> STACK TRACE FOR TASK: 0xe0000001cc458000 (insmod)
>
> ================================
Make sure you have the following, which will synthesize switch_stacks
for running tasks. This is already in the latest from
lkcd.sourceforge.net and in newer SUSE kernels.
Index: linux/drivers/dump/dump_fmt.c
=================================--- linux.orig/drivers/dump/dump_fmt.c 2004-11-18 11:13:46.454793251 -0800
+++ linux/drivers/dump/dump_fmt.c 2004-11-18 11:14:12.551656418 -0800
@@ -194,19 +194,8 @@
void dump_lcrash_save_context(int cpu, const struct pt_regs *regs,
struct task_struct *tsk)
{
- dump_header_asm.dha_smp_current_task[cpu] = (unsigned long)tsk;
- if (regs)
- __dump_save_regs(&dump_header_asm.dha_smp_regs[cpu], regs);
-
- /* take a snapshot of the stack */
- /* doing this enables us to tolerate slight drifts on this cpu */
-
- if (dump_header_asm.dha_stack[cpu]) {
- memcpy((void *)dump_header_asm.dha_stack[cpu],
- STACK_START_POSITION(tsk),
- THREAD_SIZE);
- }
- dump_header_asm.dha_stack_ptr[cpu] = (unsigned long)(tsk->thread_info);
+ /* This level of abstraction might be redundantly redundant */
+ __dump_save_context(cpu, regs, tsk);
}
/* write out the header */
Index: linux/drivers/dump/dump_i386.c
=================================--- linux.orig/drivers/dump/dump_i386.c 2004-11-18 11:13:46.454793251 -0800
+++ linux/drivers/dump/dump_i386.c 2004-11-18 11:14:12.556539265 -0800
@@ -90,6 +90,23 @@
}
}
+void
+__dump_save_context(int cpu, const struct pt_regs *regs,
+ struct task_struct *tsk)
+{
+ dump_header_asm.dha_smp_current_task[cpu] = (unsigned long)tsk;
+ __dump_save_regs(&dump_header_asm.dha_smp_regs[cpu], regs);
+
+ /* take a snapshot of the stack */
+ /* doing this enables us to tolerate slight drifts on this cpu */
+
+ if (dump_header_asm.dha_stack[cpu]) {
+ memcpy((void *)dump_header_asm.dha_stack[cpu],
+ STACK_START_POSITION(tsk),
+ THREAD_SIZE);
+ }
+ dump_header_asm.dha_stack_ptr[cpu] = (unsigned long)(tsk->thread_info);
+}
#ifdef CONFIG_SMP
extern cpumask_t irq_affinity[];
Index: linux/drivers/dump/dump_ia64.c
=================================--- linux.orig/drivers/dump/dump_ia64.c 2004-11-18 11:13:46.454793251 -0800
+++ linux/drivers/dump/dump_ia64.c 2004-11-18 11:14:12.651266493 -0800
@@ -69,20 +69,45 @@
return 0;
}
+/* a structure to get arguments into the following callback routine */
+struct unw_args {
+ int cpu;
+ struct task_struct *tsk;
+};
+
+static void
+do_save_sw(struct unw_frame_info *info, void *arg)
+{
+ struct unw_args *uwargs = (struct unw_args *)arg;
+ int cpu = uwargs->cpu;
+ struct task_struct *tsk = uwargs->tsk;
+
+ dump_header_asm.dha_stack_ptr[cpu] = (uint64_t)info->sw;
+
+ if (tsk && dump_header_asm.dha_stack[cpu]) {
+ memcpy((void *)dump_header_asm.dha_stack[cpu],
+ STACK_START_POSITION(tsk),
+ THREAD_SIZE);
+ }
+}
+
void
-__dump_save_regs(struct pt_regs *dest_regs, const struct pt_regs *regs)
+__dump_save_context(int cpu, const struct pt_regs *regs,
+ struct task_struct *tsk)
{
- *dest_regs = *regs;
+ struct unw_args uwargs;
- /* In case of panic dumps, we collects regs on entry to panic.
- * so, we shouldn't 'fix' ssesp here again. But it is hard to
- * tell just looking at regs whether ssesp need fixing. We make
- * this decision by looking at xss in regs. If we have better
- * means to determine that ssesp are valid (by some flag which
- * tells that we are here due to panic dump), then we can use
- * that instead of this kludge.
- */
-
+ dump_header_asm.dha_smp_current_task[cpu] = (unsigned long)tsk;
+
+ if (regs) {
+ dump_header_asm.dha_smp_regs[cpu] = *regs;
+ }
+
+ /* save a snapshot of the stack in a nice state for unwinding */
+ uwargs.cpu = cpu;
+ uwargs.tsk = tsk;
+
+ unw_init_running(do_save_sw, (void *)&uwargs);
}
#ifdef CONFIG_SMP
Index: linux/drivers/dump/dump_ppc64.c
=================================--- linux.orig/drivers/dump/dump_ppc64.c 2004-11-18 11:13:46.454793251 -0800
+++ linux/drivers/dump/dump_ppc64.c 2004-11-18 11:14:12.567281528 -0800
@@ -219,6 +219,24 @@
return 0 /* FIXME */ ;
}
+void
+__dump_save_context(int cpu, const struct pt_regs *regs,
+ struct task_struct *tsk)
+{
+ dump_header_asm.dha_smp_current_task[cpu] = (unsigned long)tsk;
+ __dump_save_regs(&dump_header_asm.dha_smp_regs[cpu], regs);
+
+ /* take a snapshot of the stack */
+ /* doing this enables us to tolerate slight drifts on this cpu */
+
+ if (dump_header_asm.dha_stack[cpu]) {
+ memcpy((void *)dump_header_asm.dha_stack[cpu],
+ STACK_START_POSITION(tsk),
+ THREAD_SIZE);
+ }
+ dump_header_asm.dha_stack_ptr[cpu] = (unsigned long)(tsk->thread_info);
+}
+
/*
* Name: __dump_configure_header()
* Func: Configure the dump header with all proper values.
Index: linux/drivers/dump/dump_x8664.c
=================================--- linux.orig/drivers/dump/dump_x8664.c 2004-11-18 11:13:46.455769820 -0800
+++ linux/drivers/dump/dump_x8664.c 2004-11-18 11:14:12.572164374 -0800
@@ -76,6 +76,24 @@
memcpy(dest_regs, regs, sizeof(struct pt_regs));
}
+void
+__dump_save_context(int cpu, const struct pt_regs *regs,
+ struct task_struct *tsk)
+{
+ dump_header_asm.dha_smp_current_task[cpu] = (unsigned long)tsk;
+ __dump_save_regs(&dump_header_asm.dha_smp_regs[cpu], regs);
+
+ /* take a snapshot of the stack */
+ /* doing this enables us to tolerate slight drifts on this cpu */
+
+ if (dump_header_asm.dha_stack[cpu]) {
+ memcpy((void *)dump_header_asm.dha_stack[cpu],
+ STACK_START_POSITION(tsk),
+ THREAD_SIZE);
+ }
+ dump_header_asm.dha_stack_ptr[cpu] = (unsigned long)(tsk->thread_info);
+}
+
#ifdef CONFIG_SMP
extern cpumask_t irq_affinity[];
extern irq_desc_t irq_desc[];
Index: linux/include/linux/dump.h
=================================--- linux.orig/include/linux/dump.h 2004-11-18 11:13:46.455769820 -0800
+++ linux/include/linux/dump.h 2004-11-18 11:14:12.587789484 -0800
@@ -408,6 +408,7 @@
extern void __dump_cleanup(void);
extern void __dump_init(u64);
extern void __dump_save_regs(struct pt_regs *, const struct pt_regs *);
+extern void __dump_save_context(int cpu, const struct pt_regs *, struct task_struct *tsk);
extern int __dump_configure_header(const struct pt_regs *);
extern int __dump_irq_enable(void);
extern void __dump_irq_restore(void);
^ permalink raw reply [flat|nested] 4+ messages in thread