From: Andrew Morton <akpm@osdl.org>
To: Jes Sorensen <jes@wildopensource.com>
Cc: matthew@wil.cx, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch -mm series] ia64 specific /dev/mem handlers
Date: Tue, 22 Feb 2005 23:34:56 +0000 [thread overview]
Message-ID: <20050222153456.502c3907.akpm@osdl.org> (raw)
In-Reply-To: <yq0zmxwgqxr.fsf@jaguar.mkp.net>
Jes Sorensen <jes@wildopensource.com> wrote:
>
> After applying the clue 2x4 to my head a couple of times, I came up
> with this patch. Hopefully it will work a bit better ;-)
>
I know it's repetitious, but it's nice to maintain a changelog entry along
with the patch. Especially when seventy people have asked "wtf is this patch
for?".
Implementation-wise, do you really need to clone-and-own the mem.c
functions? Would it not be sufficient to do
ptr = arch_translate_mem_ptr(page, ptr);
inside mem.c?
> + * arch/ia64/kernel/mem.c
> ...
> +extern loff_t memory_lseek(struct file * file, loff_t offset, int orig);
> +extern int mmap_kmem(struct file * file, struct vm_area_struct * vma);
> +extern int open_port(struct inode * inode, struct file * filp);
> +
Please find a .h file for the function prototypes.
next prev parent reply other threads:[~2005-02-22 23:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-22 9:52 [patch -mm series] ia64 specific /dev/mem handlers Jes Sorensen
2005-02-22 10:03 ` Andrew Morton
2005-02-22 12:08 ` Andi Kleen
2005-02-22 14:41 ` Jes Sorensen
2005-02-22 17:52 ` Matthew Wilcox
2005-02-22 19:25 ` Andrew Morton
2005-02-22 19:35 ` Dave Hansen
2005-02-22 21:38 ` Jes Sorensen
2005-02-23 0:48 ` Dave Hansen
2005-02-22 21:34 ` Jes Sorensen
2005-02-22 22:39 ` Jes Sorensen
2005-02-22 23:34 ` Andrew Morton [this message]
2005-02-23 10:01 ` Jes Sorensen
2005-02-23 22:34 ` Christoph Hellwig
2005-02-24 16:11 ` Jes Sorensen
2005-03-10 6:55 ` Andrew Morton
2005-03-10 13:49 ` Jes Sorensen
2005-02-22 18:05 ` Luck, Tony
2005-02-22 22:03 ` Arjan van de Ven
2005-02-22 22:30 ` Jes Sorensen
2005-02-22 22:42 ` Arjan van de Ven
2005-02-23 8:12 ` Jes Sorensen
2005-02-23 8:24 ` Arjan van de Ven
2005-03-03 11:37 ` Andrew Morton
2005-03-03 12:53 ` Jes Sorensen
2005-03-04 12:26 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050222153456.502c3907.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jes@wildopensource.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox