From: Andrew Morton <akpm@osdl.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: jes@wildopensource.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch -mm series] ia64 specific /dev/mem handlers
Date: Tue, 22 Feb 2005 19:25:13 +0000 [thread overview]
Message-ID: <20050222112513.4162860d.akpm@osdl.org> (raw)
In-Reply-To: <20050222175225.GK28741@parcelfarce.linux.theplanet.co.uk>
Matthew Wilcox <matthew@wil.cx> wrote:
>
> On Tue, Feb 22, 2005 at 09:41:04AM -0500, Jes Sorensen wrote:
> > >> + if (page->flags & PG_uncached)
> >
> > Andrew> dude. That ain't gonna work ;)
> >
> > Pardon my lack of clue, but why not?
if (page->flags & (1<<PG_uncached))
would have been correcter.
> I think you're supposed to always use test_bit() to check page flags
Yup. Add PageUncached macros to page-flags.h.
next prev parent reply other threads:[~2005-02-22 19:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-22 9:52 [patch -mm series] ia64 specific /dev/mem handlers Jes Sorensen
2005-02-22 10:03 ` Andrew Morton
2005-02-22 12:08 ` Andi Kleen
2005-02-22 14:41 ` Jes Sorensen
2005-02-22 17:52 ` Matthew Wilcox
2005-02-22 19:25 ` Andrew Morton [this message]
2005-02-22 19:35 ` Dave Hansen
2005-02-22 21:38 ` Jes Sorensen
2005-02-23 0:48 ` Dave Hansen
2005-02-22 21:34 ` Jes Sorensen
2005-02-22 22:39 ` Jes Sorensen
2005-02-22 23:34 ` Andrew Morton
2005-02-23 10:01 ` Jes Sorensen
2005-02-23 22:34 ` Christoph Hellwig
2005-02-24 16:11 ` Jes Sorensen
2005-03-10 6:55 ` Andrew Morton
2005-03-10 13:49 ` Jes Sorensen
2005-02-22 18:05 ` Luck, Tony
2005-02-22 22:03 ` Arjan van de Ven
2005-02-22 22:30 ` Jes Sorensen
2005-02-22 22:42 ` Arjan van de Ven
2005-02-23 8:12 ` Jes Sorensen
2005-02-23 8:24 ` Arjan van de Ven
2005-03-03 11:37 ` Andrew Morton
2005-03-03 12:53 ` Jes Sorensen
2005-03-04 12:26 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050222112513.4162860d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jes@wildopensource.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox