public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@engr.sgi.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] remove redundant irq_affinity definition
Date: Mon, 14 Mar 2005 19:28:01 +0000	[thread overview]
Message-ID: <200503141128.01855.jbarnes@engr.sgi.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

gcc4 complains about multiple definitions of irq_affinity--I think the one in 
arch/ia64/kernel/irq.c is the redundant one since the array is also defined 
in kernel/irq/manage.c.

Building with gcc4 generates a bunch of warnings too, saying that qualifiers 
on function return types are being ignored (in particular the ones from 
__ia64_get_io_port_base and the ones having to do with mmu_context_t being 
volatile).  Should we use attribute(const) for get_io_port_base?  What about 
for the mmu_context_t functions?

Signed-off-by: Jesse Barnes <jbarnes@sgi.com>

Jesse

[-- Attachment #2: generic-irqs-ia64-fix.patch --]
[-- Type: text/plain, Size: 533 bytes --]

===== arch/ia64/kernel/irq.c 1.55 vs edited =====
--- 1.55/arch/ia64/kernel/irq.c	2005-01-22 15:54:25 -08:00
+++ edited/arch/ia64/kernel/irq.c	2005-03-14 11:24:20 -08:00
@@ -97,7 +97,6 @@
 cpumask_t __cacheline_aligned pending_irq_cpumask[NR_IRQS];
 static unsigned long pending_irq_redir[BITS_TO_LONGS(NR_IRQS)];
 
-static cpumask_t irq_affinity [NR_IRQS] = { [0 ... NR_IRQS-1] = CPU_MASK_ALL };
 static char irq_redir [NR_IRQS]; // = { [0 ... NR_IRQS-1] = 1 };
 
 void set_irq_affinity_info (unsigned int irq, int hwid, int redir)

             reply	other threads:[~2005-03-14 19:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-14 19:28 Jesse Barnes [this message]
2005-03-14 19:36 ` [PATCH] remove redundant irq_affinity definition David Mosberger
2005-03-14 19:51 ` Ashok Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503141128.01855.jbarnes@engr.sgi.com \
    --to=jbarnes@engr.sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox