[patch 1/1] printk : arch/ia64/kernel/smp.c

[patch 1/1] printk : arch/ia64/kernel/smp.c

[domen]

printk() calls should include appropriate KERN_* constant.

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
Signed-off-by: Domen Puncer <domen@coderock.org>
---


 kj-domen/arch/ia64/kernel/smp.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/ia64/kernel/smp.c~printk-arch_ia64_kernel_smp arch/ia64/kernel/smp.c
--- kj/arch/ia64/kernel/smp.c~printk-arch_ia64_kernel_smp	2005-03-18 20:05:41.000000000 +0100
+++ kj-domen/arch/ia64/kernel/smp.c	2005-03-18 20:05:41.000000000 +0100
@@ -269,7 +269,7 @@ smp_call_function_single (int cpuid, voi
 	int me = get_cpu(); /* prevent preemption and reschedule on another processor */
 
 	if (cpuid = me) {
-		printk("%s: trying to call self\n", __FUNCTION__);
+		printk(KERN_INFO "%s: trying to call self\n", __FUNCTION__);
 		put_cpu();
 		return -EBUSY;
 	}
_

RE: [patch 1/1] printk : arch/ia64/kernel/smp.c

[Luck, Tony]

> 	if (cpuid = me) {
>-		printk("%s: trying to call self\n", __FUNCTION__);
>+		printk(KERN_INFO "%s: trying to call self\n", __FUNCTION__);
> 		put_cpu();
> 		return -EBUSY;
> 	}

I think this is a bit higher priority than KERN_INFO.  If we
get here, then someone did something wrong at a higher level,
and they may be disapponited that the function they want called
isn't going to be called.

Perhaps KERN_WARNING would be more appropriate?

It might also be kind to anyone trying to debug this to print
the "func" argument.

-Tony

Re: [patch 1/1] printk : arch/ia64/kernel/smp.c

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

Luck, Tony (tony.luck@intel.com) wrote:
> > 	if (cpuid == me) {
> >-		printk("%s: trying to call self\n", __FUNCTION__);
> >+		printk(KERN_INFO "%s: trying to call self\n", __FUNCTION__);
> > 		put_cpu();
> > 		return -EBUSY;
> > 	}
> 
> I think this is a bit higher priority than KERN_INFO.  If we
> get here, then someone did something wrong at a higher level,
> and they may be disapponited that the function they want called
> isn't going to be called.
> 
> Perhaps KERN_WARNING would be more appropriate?
> 
> It might also be kind to anyone trying to debug this to print
> the "func" argument.
> 
> -Tony
> 

Perhaps this could do the job:



[-- Attachment #2: patch-linux-2.6.12-rc1_arch_ia64_kernel_smp.c.diff --]
[-- Type: text/plain, Size: 548 bytes --]

diff -uprN -X dontdiff a/arch/ia64/kernel/smp.c b/arch/ia64/kernel/smp.c
--- a/arch/ia64/kernel/smp.c	2005-03-18 02:34:36.000000000 +0100
+++ b/arch/ia64/kernel/smp.c	2005-03-23 10:35:18.000000000 +0100
@@ -269,7 +269,7 @@ smp_call_function_single (int cpuid, voi
 	int me = get_cpu(); /* prevent preemption and reschedule on another processor */
 
 	if (cpuid == me) {
-		printk("%s: trying to call self\n", __FUNCTION__);
+		printk(KERN_WARNING "%s: trying to call self with info:%08x\n", __FUNCTION__, info);
 		put_cpu();
 		return -EBUSY;
 	}

Re: [patch 1/1] printk : arch/ia64/kernel/smp.c

[Domen Puncer]

On 23/03/05 11:02 +0100, Christophe Lucas wrote:
>  	if (cpuid = me) {
> -		printk("%s: trying to call self\n", __FUNCTION__);
> +		printk(KERN_WARNING "%s: trying to call self with info:%08x\n", __FUNCTION__, info);

Hmm... %p is supposed to be used for pointers, right?



	Domen

[patch 1/1] printk : arch/ia64/kernel/smp.c

[domen]

From: Christophe Lucas <clucas@rotomalug.org>



printk() calls should include appropriate KERN_* constant.

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
 smp.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: quilt/arch/ia64/kernel/smp.c
=================================--- quilt.orig/arch/ia64/kernel/smp.c
+++ quilt/arch/ia64/kernel/smp.c
@@ -269,7 +269,7 @@ smp_call_function_single (int cpuid, voi
 	int me = get_cpu(); /* prevent preemption and reschedule on another processor */
 
 	if (cpuid = me) {
-		printk("%s: trying to call self\n", __FUNCTION__);
+		printk(KERN_INFO "%s: trying to call self\n", __FUNCTION__);
 		put_cpu();
 		return -EBUSY;
 	}

--