From: Greg KH <greg@kroah.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH 3/91] get rid of pci_find_{device,subsys} arch/ia64
Date: Wed, 30 Mar 2005 05:58:19 +0000 [thread overview]
Message-ID: <20050330055819.GB10231@kroah.com> (raw)
In-Reply-To: <20050329122242.GA26755@infradead.org>
On Tue, Mar 29, 2005 at 05:50:09PM +0530, Amit Gud wrote:
> Replace pci_find_{device,subsys} with pci_get_{device,subsys}.
>
>
>
> Signed-off-by: Amit Gud <gud@eth.net>
>
> ---
> diff -upr orig-2.6.12-rc1/arch/ia64/sn/kernel/io_init.c work-2.6.12-rc1/arch/ia64/sn/kernel/io_init.c
> --- orig-2.6.12-rc1/arch/ia64/sn/kernel/io_init.c 2005-03-15 21:00:10.000000000 +0530
> +++ work-2.6.12-rc1/arch/ia64/sn/kernel/io_init.c 2005-03-24 15:29:23.539955472 +0530
> @@ -365,8 +365,9 @@ static int __init sn_pci_init(void)
> */
>
> while ((pci_dev > - pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pci_dev)) != NULL) {
> + pci_get_device(PCI_ANY_ID, PCI_ANY_ID, pci_dev)) != NULL) {
> sn_pci_fixup_slot(pci_dev);
> + pci_dev_put(dev);
> }
Argh, no, this is wrong. And I think you did this in every one of the
patches you sent out, so please send a retraction for every one of them
too, I don't feel like doing it...
You should not do a pci_dev_put() in a loop like this. Please go read
the documentation for the pci_get_device() function, it explains how to
use it...
So, sorry, but I'm not going to apply any of these patches.
Next time try sending just a few of them out, to see what the reaction
is, and if you are doing it properly.
greg k-h
next prev parent reply other threads:[~2005-03-30 5:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 12:22 [PATCH 3/91] get rid of pci_find_{device,subsys} arch/ia64 Christoph Hellwig
2005-03-29 12:32 ` Amit Gud
2005-03-29 14:18 ` Amit Gud
2005-03-30 5:58 ` Greg KH [this message]
2005-03-30 6:53 ` Amit Gud
2005-03-30 9:45 ` Greg KH
2005-03-30 10:31 ` Amit Gud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050330055819.GB10231@kroah.com \
--to=greg@kroah.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox