public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH 3/91] get rid of pci_find_{device,subsys} arch/ia64
Date: Wed, 30 Mar 2005 09:45:51 +0000	[thread overview]
Message-ID: <20050330094550.GA12553@kroah.com> (raw)
In-Reply-To: <20050329122242.GA26755@infradead.org>

On Wed, Mar 30, 2005 at 12:29:00PM +0530, Amit Gud wrote:
> So if we are to replace pci_find_device with pci_get_device, how should we 
> go about in this particular case, which
> apparently is the case with many other places where pci_find_device is 
> used. The way I did seemed logical to me:
> find the device - accept it - work with it - jerk it off.
> Am I missing out something very obvious?

Please read the last sentence of the documentation for the
pci_get_device() function.  I think you missed that :)

That sentence tells us that you do not need to call pci_dev_put() within
a pci_get_device() while loop.

So please, email all of the maintainers who you sent those patches to
and ask them to not apply them...

thanks,

greg k-h

  parent reply	other threads:[~2005-03-30  9:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-29 12:22 [PATCH 3/91] get rid of pci_find_{device,subsys} arch/ia64 Christoph Hellwig
2005-03-29 12:32 ` Amit Gud
2005-03-29 14:18 ` Amit Gud
2005-03-30  5:58 ` Greg KH
2005-03-30  6:53 ` Amit Gud
2005-03-30  9:45 ` Greg KH [this message]
2005-03-30 10:31 ` Amit Gud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050330094550.GA12553@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox