From: Jerry Feldman <gerald.feldman@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: Incorrect return types for atomic64 functions in IA64 atomic.h
Date: Fri, 29 Apr 2005 19:39:12 +0000 [thread overview]
Message-ID: <200504291539.12924.gerald.feldman@hp.com> (raw)
In-Reply-To: <200504291443.16040.gerald.feldman@hp.com>
On Friday 29 April 2005 3:10 pm, Andreas Schwab wrote:
> Jerry Feldman <gerald.feldman@hp.com> writes:
> > @@ -124,7 +124,7 @@ atomic_add_negative (int i, atomic_t *v)
> > return atomic_add_return(i, v) < 0;
> > }
> >
> > -static __inline__ int
> > +static __inline__ __s64
> > atomic64_add_negative (__s64 i, atomic64_t *v)
> > {
> > return atomic64_add_return(i, v) < 0;
>
> This is wrong. The return value is a boolean.
I agree. Should I resubmit the patch corrected, or will someone else do it.
--
Jerry Feldman <gerald.feldman@hp.com>
Partner Technology Access Center (contractor) (PTAC-MA)
Hewlett-Packard Co.
550 King Street LKG2a-X2
Littleton, Ma. 01460
(978)506-5243
next prev parent reply other threads:[~2005-04-29 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-29 18:43 Incorrect return types for atomic64 functions in IA64 atomic.h Jerry Feldman
2005-04-29 19:10 ` Andreas Schwab
2005-04-29 19:39 ` Jerry Feldman [this message]
2005-04-29 19:48 ` Incorrect return types for atomic64 functions in IA64 atomic.h (corrected) Jerry Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504291539.12924.gerald.feldman@hp.com \
--to=gerald.feldman@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox