Linux IA64 platform development
 help / color / mirror / Atom feed
* scheduler cache-hot-auto-tune patch breaks ia64 UP build
@ 2005-06-21 22:03 Lynch, Rusty
  2005-06-21 22:51 ` Chen, Kenneth W
  0 siblings, 1 reply; 2+ messages in thread
From: Lynch, Rusty @ 2005-06-21 22:03 UTC (permalink / raw)
  To: Ingo Molnar, Andrew Morton; +Cc: linux-kernel, linux-ia64

Attempting to build 2.6.12-mm1 on ia64 with CONFIG_SMP disabled will
cause the build to break because max_cache_size is undefined.  I haven't
spent the time to understand the cache-hot-auto-tune feature, so I don't
have a patch to fix the problem.

    --rusty

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: scheduler cache-hot-auto-tune patch breaks ia64 UP build
  2005-06-21 22:03 scheduler cache-hot-auto-tune patch breaks ia64 UP build Lynch, Rusty
@ 2005-06-21 22:51 ` Chen, Kenneth W
  0 siblings, 0 replies; 2+ messages in thread
From: Chen, Kenneth W @ 2005-06-21 22:51 UTC (permalink / raw)
  To: Lynch, Rusty, Ingo Molnar, Andrew Morton; +Cc: linux-kernel, linux-ia64

Lynch, Rusty wrote on Tuesday, June 21, 2005 3:04 PM
> Attempting to build 2.6.12-mm1 on ia64 with CONFIG_SMP disabled will
> cause the build to break because max_cache_size is undefined.  I haven't
> spent the time to understand the cache-hot-auto-tune feature, so I don't
> have a patch to fix the problem.

It needs a #ifdef around max_cache_size.  Patch to fix the build problem.


Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>

--- linux-2.6.12/arch/ia64/kernel/setup.c.orig	2005-06-21 15:46:16.418636538 -0700
+++ linux-2.6.12/arch/ia64/kernel/setup.c	2005-06-21 15:46:34.496761317 -0700
@@ -655,7 +655,9 @@ get_max_cacheline_size (void)
 			cache_size = cci.pcci_cache_size;
         }
   out:
+#ifdef CONFIG_SMP
 	max_cache_size = max(max_cache_size, cache_size);
+#endif
 	if (max > ia64_max_cacheline_size)
 		ia64_max_cacheline_size = max;
 }


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-06-21 22:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-21 22:03 scheduler cache-hot-auto-tune patch breaks ia64 UP build Lynch, Rusty
2005-06-21 22:51 ` Chen, Kenneth W

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox