From: Jesse Barnes <jesse.barnes@intel.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] pcibus_to_node implementation for IA64
Date: Thu, 23 Jun 2005 21:10:07 +0000 [thread overview]
Message-ID: <200506231410.07739.jesse.barnes@intel.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0506231400360.13123@schroedinger.engr.sgi.com>
On Thursday, June 23, 2005 2:02 pm, Christoph Lameter wrote:
> -0700 @@ -109,6 +109,7 @@ struct pci_controller {
> void *acpi_handle;
> void *iommu;
> int segment;
> + int node; /* nearest node with memory or -1 for global allocation
> */
...
> +#ifdef CONFIG_NUMA
> + PCI_CONTROLLER(bus)->node = ioc->node;
> +#endif
> return;
> }
It looks like you're adding the new 'node' field unconditionally, but
protecting the sba assignment by CONFIG_NUMA? Which one is wrong? :)
Jesse
next prev parent reply other threads:[~2005-06-23 21:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 21:02 [PATCH] pcibus_to_node implementation for IA64 Christoph Lameter
2005-06-23 21:10 ` Jesse Barnes [this message]
2005-06-23 21:17 ` Alex Williamson
2005-06-23 21:19 ` Christoph Lameter
2005-06-23 21:20 ` Christoph Lameter
2005-06-23 21:33 ` Alex Williamson
2005-06-23 21:47 ` Christoph Lameter
2005-06-23 22:53 ` Alex Williamson
2005-06-23 23:08 ` Christoph Lameter
2005-06-24 1:31 ` Jack Steiner
2005-06-24 2:11 ` Christoph Lameter
2005-07-07 23:59 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506231410.07739.jesse.barnes@intel.com \
--to=jesse.barnes@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox