From: Jack Steiner <steiner@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] pcibus_to_node implementation for IA64
Date: Fri, 24 Jun 2005 01:31:32 +0000 [thread overview]
Message-ID: <20050624013132.GA19726@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0506231400360.13123@schroedinger.engr.sgi.com>
> Index: linux-2.6.12/arch/ia64/sn/kernel/io_init.c
> =================================> --- linux-2.6.12.orig/arch/ia64/sn/kernel/io_init.c 2005-06-17 12:48:29.000000000 -0700
> +++ linux-2.6.12/arch/ia64/sn/kernel/io_init.c 2005-06-23 13:55:02.000000000 -0700
> @@ -364,6 +364,8 @@ static void sn_pci_controller_fixup(int
>
> nasid = NASID_GET(SN_PCIBUS_BUSSOFT(bus)->bs_base);
> cnode = nasid_to_cnodeid(nasid);
> + if (cnode < num_online_nodes() && cnode < numionodes)
> + controller->node = cnode;
This doesn't look right.
The code works for normal nodes (not TIO). For TIO nodes, the node number that
is returned by physical_node_map() is NOT a node number that is known to
VM.
> hubdev_info = (struct hubdev_info *)(NODEPDA(cnode)->pdinfo);
> SN_PCIBUS_BUSSOFT(bus)->bs_xwidget_info > &(hubdev_info->hdi_xwidget_info[SN_PCIBUS_BUSSOFT(bus)->bs_xid]);
--
Thanks
Jack Steiner (steiner@sgi.com) 651-683-5302
Principal Engineer SGI - Silicon Graphics, Inc.
next prev parent reply other threads:[~2005-06-24 1:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 21:02 [PATCH] pcibus_to_node implementation for IA64 Christoph Lameter
2005-06-23 21:10 ` Jesse Barnes
2005-06-23 21:17 ` Alex Williamson
2005-06-23 21:19 ` Christoph Lameter
2005-06-23 21:20 ` Christoph Lameter
2005-06-23 21:33 ` Alex Williamson
2005-06-23 21:47 ` Christoph Lameter
2005-06-23 22:53 ` Alex Williamson
2005-06-23 23:08 ` Christoph Lameter
2005-06-24 1:31 ` Jack Steiner [this message]
2005-06-24 2:11 ` Christoph Lameter
2005-07-07 23:59 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050624013132.GA19726@sgi.com \
--to=steiner@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox